Re: [PATCH] Dynamic tick for x86 version 050602-1

Christian Hesse
2005-06-02T08:57:04Z

[-- Attachment #1: Type: text/plain, Size: 2073 bytes --]

On Thursday 02 June 2005 03:36, Tony Lindgren wrote:
> Hi all,
>
> Here's an updated version of the dynamic tick patch.
>
> It's mostly clean-up and it's now using the standard
> monotonic_clock() functions as suggested by John Stultz.
>
> Please let me know of any issues with the patch. I'll continue to do
> more clean-up on it, but I think the basic functionality is done.

I would like to test it, but have some trouble. The patch applies cleanly and
everything compiles fine, but linking fails:

# ld -m elf_i386 -R arch/i386/kernel/vsyscall-syms.o -r -o
arch/i386/kernel/built-in.o arch/i386/kernel/process.o
arch/i386/kernel/semaphore.o arch/i386/kernel/signal.o
arch/i386/kernel/entry.o arch/i386/kernel/traps.o arch/i386/kernel/irq.o
arch/i386/kernel/vm86.o arch/i386/kernel/ptrace.o arch/i386/kernel/time.o
arch/i386/kernel/ioport.o arch/i386/kernel/ldt.o arch/i386/kernel/setup.o
arch/i386/kernel/i8259.o arch/i386/kernel/sys_i386.o
arch/i386/kernel/pci-dma.o arch/i386/kernel/i386_ksyms.o
arch/i386/kernel/i387.o arch/i386/kernel/dmi_scan.o
arch/i386/kernel/bootflag.o arch/i386/kernel/doublefault.o
arch/i386/kernel/quirks.o arch/i386/kernel/cpu/built-in.o
arch/i386/kernel/timers/built-in.o arch/i386/kernel/acpi/built-in.o
arch/i386/kernel/reboot.o arch/i386/kernel/module.o
arch/i386/kernel/sysenter.o arch/i386/kernel/vsyscall.o
arch/i386/kernel/dyn-tick.o arch/i386/kernel/early_printk.o
arch/i386/kernel/irq.o: In function `reprogram_apic_timer':
irq.c:(.text+0x0): multiple definition of `reprogram_apic_timer'
arch/i386/kernel/process.o:process.c:(.text+0x0): first defined here
arch/i386/kernel/time.o: In function `reprogram_apic_timer':
time.c:(.text+0x0): multiple definition of `reprogram_apic_timer'
arch/i386/kernel/process.o:process.c:(.text+0x0): first defined here
arch/i386/kernel/dyn-tick.o: In function `reprogram_apic_timer':
dyn-tick.c:(.text+0x0): multiple definition of `reprogram_apic_timer'
arch/i386/kernel/process.o:process.c:(.text+0x0): first defined here

--
Christian

[-- Attachment #2: Type: application/pgp-signature, Size: 190 bytes --]