public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Abhay_Salunke@Dell.com
Cc: marcel@holtmann.org, linux-kernel@vger.kernel.org, akpm@osdl.org,
	Matt_Domsch@Dell.com
Subject: Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new DellBIOS update driver
Date: Fri, 3 Jun 2005 11:03:36 -0700	[thread overview]
Message-ID: <20050603180336.GA5502@kroah.com> (raw)
In-Reply-To: <367215741E167A4CA813C8F12CE0143B3ED3A5@ausx2kmpc115.aus.amer.dell.com>

On Fri, Jun 03, 2005 at 08:30:44AM -0500, Abhay_Salunke@Dell.com wrote:
> 
> 
> > 
> > No no no.  Just because you are using the firmware interface, does not
> > mean you need to add this extra round-trip to the whole system.  Just
> > dump the firmware to the /sys/firmware/whatever... file whenever you
> > want to, that's all that is needed.  No hotplug stuff, no filename
> > stuff, just a simple copy.
> Greg, all the feedback gave the impression that request_firmwae hotplug
> stuff was the way to go.

It is the way to go.

> Seems it's not required!

Not at all, why do you think I mean that?

> Now that means it needs to be done the way it was before except that
> it needs to have a bin attribute for data and a normal attribute for
> size.  This would be even better as it makes it easy to read back the
> data.

No, you can still use the firmware core code, that's what it is there
for.  But don't mess with the "make the user provide a filename" stuff.
Just have your driver create the firmware request and then relax.  Your
code will get called when the firware is written to, right?  That's all
you need.

What's with this obsession about firmware filenames... :)

thanks,

greg k-h

  parent reply	other threads:[~2005-06-03 18:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 13:30 [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new DellBIOS update driver Abhay_Salunke
2005-06-03 16:53 ` Marcel Holtmann
2005-06-03 18:03 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-06-07 14:47 Abhay_Salunke
2005-06-07 15:01 ` Greg KH
2005-06-06 20:22 Abhay_Salunke
2005-06-06 20:35 ` Greg KH
2005-06-06 20:01 Abhay_Salunke
2005-06-06 20:12 ` Greg KH
2005-06-06 18:54 Abhay_Salunke
2005-06-06 19:22 ` Greg KH
2005-06-06 16:27 Abhay_Salunke
2005-06-06 18:16 ` Greg KH
2005-06-03 19:57 Abhay_Salunke
2005-06-03 20:33 ` Greg KH
2005-06-03 19:00 Abhay_Salunke
2005-06-03 19:29 ` Greg KH
2005-06-02 22:25 Abhay_Salunke
2005-06-02 22:45 ` Marcel Holtmann
2005-06-02 22:50 ` Andrew Morton
2005-06-03  5:19 ` Greg KH
2005-05-23 15:36 Abhay_Salunke
2005-05-23 15:50 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050603180336.GA5502@kroah.com \
    --to=greg@kroah.com \
    --cc=Abhay_Salunke@Dell.com \
    --cc=Matt_Domsch@Dell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox