From: Christoph Hellwig <hch@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Arjan van de Ven <arjanv@infradead.org>,
Roman Zippel <zippel@linux-m68k.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Ingo Oeser <ioe-lkml@axxeo.de>, Andrew Morton <akpm@osdl.org>,
Christoph Hellwig <hch@infradead.org>, Andi Kleen <ak@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
Al Viro <viro@parcelfarce.linux.theplanet.co.uk>,
"David S. Miller" <davem@redhat.com>
Subject: Re: [patch] spinlock consolidation, v2
Date: Sat, 4 Jun 2005 12:38:09 +0100 [thread overview]
Message-ID: <20050604113809.GD19819@infradead.org> (raw)
In-Reply-To: <20050603154029.GA2995@elte.hu>
On Fri, Jun 03, 2005 at 05:40:29PM +0200, Ingo Molnar wrote:
>
> the latest version of the spinlock consolidation patch can be found at:
>
> http://redhat.com/~mingo/spinlock-patches/consolidate-spinlocks.patch
>
> the patch is now complete in the sense that it does everything i wanted
> it to do. If you have any other suggestions (or i have missed to
> incorporate an earlier suggestion of yours), please yell.
Looks pretty nice, but your usage of asm-generic is totally wrong.
files in asm-generic must only ever be used for default implementations
of asm/ headers, and _never_ be included from common code. But your
asm-generic files are only ever used from linux/spinlock.h, so there's
no point at all in splitting them out in the first time.
Similarly there's no point in a separate linux/spinlock_smp.h and
linux/spinlock_up.h - it'll only cause some driver writers to include
either of them directly and break the build for either UP or SMP.
If you absolutely want to split them add an #error if not included from
spinlock.h
Little nitpick no 2: please include linux/*.h always before asm/*.h
(in linux/jbd.h)
next prev parent reply other threads:[~2005-06-04 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-03 15:40 [patch] spinlock consolidation, v2 Ingo Molnar
2005-06-04 11:38 ` Christoph Hellwig [this message]
2005-06-05 10:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050604113809.GD19819@infradead.org \
--to=hch@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjanv@infradead.org \
--cc=davem@redhat.com \
--cc=ioe-lkml@axxeo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
--cc=zippel@linux-m68k.org \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox