From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261264AbVFDUQV (ORCPT ); Sat, 4 Jun 2005 16:16:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261261AbVFDUQV (ORCPT ); Sat, 4 Jun 2005 16:16:21 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:51214 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S261244AbVFDUQK (ORCPT ); Sat, 4 Jun 2005 16:16:10 -0400 Date: Sat, 4 Jun 2005 21:16:04 +0100 From: Russell King To: Pierre Ossman Cc: LKML Subject: Re: [PATCH] Support for read-only MMC cards Message-ID: <20050604211604.C23449@flint.arm.linux.org.uk> Mail-Followup-To: Pierre Ossman , LKML References: <42A2070D.9060608@drzeus.cx> <20050604205810.A23449@flint.arm.linux.org.uk> <42A2096C.9010108@drzeus.cx> <20050604210733.B23449@flint.arm.linux.org.uk> <42A20B97.4080504@drzeus.cx> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <42A20B97.4080504@drzeus.cx>; from drzeus-list@drzeus.cx on Sat, Jun 04, 2005 at 10:14:15PM +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jun 04, 2005 at 10:14:15PM +0200, Pierre Ossman wrote: > Well that would turn out something like: > > printk(KERN_INFO "%s: %s %s %dKiB%s\n", > md->disk->disk_name, mmc_card_id(card), mmc_card_name(card), > (card->csd.capacity << card->csd.read_blkbits) / 1024, > (!(card->csd.cmdclass & CCC_BLOCK_WRITE) || > mmc_card_readonly(card)) ? " (ro)" : ""); > > which is a bit messy IMHO. Can't we set mmc_card_readonly status if !CCC_BLOCK_WRITE ? Would that not simplify the code in the open method as well? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core