From: Greg KH <greg@kroah.com>
To: Jean Delvare <khali@linux-fr.org>
Cc: Yani Ioannou <yani.ioannou@gmail.com>,
LM Sensors <lm-sensors@lm-sensors.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [lm-sensors] [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks
Date: Sun, 5 Jun 2005 23:14:31 -0700 [thread overview]
Message-ID: <20050606061430.GA6240@kroah.com> (raw)
In-Reply-To: <20050605105146.6f68fc94.khali@linux-fr.org>
On Sun, Jun 05, 2005 at 10:51:46AM +0200, Jean Delvare wrote:
> Hi Yani, all,
>
> > Finally (phew!) this patch demonstrates how to adapt the adm1026 to
> > take advantage of the new callbacks, and the i2c-sysfs.h defined
> > structure/macros. Most of the other sensor/hwmon drivers could be
> > updated in the same way. The odd few exceptions (bmcsensors for
> > example) however might be better off with their own custom attribute
> > structure.
>
> I just noticed that this patch has a repeated coding style error:
>
> + struct sensor_device_attribute *sensor_attr= to_sensor_dev_attr(attr);
>
> should be:
>
> + struct sensor_device_attribute *sensor_attr = to_sensor_dev_attr(attr);
>
> Can we apply this modified version instead? Or is an incremental patch
> preferred?
I've replaced the version in my tree with this one, thanks.
greg k-h
prev parent reply other threads:[~2005-06-06 7:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-17 10:47 [PATCH 2.6.12-rc4 15/15] drivers/i2c/chips/adm1026.c: use dynamic sysfs callbacks Yani Ioannou
2005-05-17 11:04 ` [lm-sensors] " Jean Delvare
2005-05-17 11:18 ` Yani Ioannou
2005-05-17 20:23 ` Grant Coady
2005-05-17 20:56 ` Yani Ioannou
2005-05-17 23:13 ` Grant Coady
2005-05-17 23:21 ` Yani Ioannou
2005-05-18 1:58 ` Grant Coady
[not found] ` <253818670505172136613abb43@mail.gmail.com>
2005-05-19 20:02 ` Jean Delvare
2005-05-19 20:52 ` Greg KH
2005-05-19 20:57 ` Jean Delvare
2005-05-19 21:35 ` Greg KH
2005-05-20 7:46 ` Jean Delvare
2005-05-20 8:53 ` Yani Ioannou
2005-05-22 1:58 ` Dmitry Torokhov
2005-05-22 6:50 ` Jean Delvare
2005-05-22 7:04 ` Dmitry Torokhov
2005-05-22 12:15 ` Yani Ioannou
2005-05-22 12:32 ` Jean Delvare
2005-05-22 13:05 ` Yani Ioannou
2005-05-22 13:39 ` Jean Delvare
2005-05-19 21:14 ` Yani Ioannou
2005-06-05 8:51 ` Jean Delvare
2005-06-06 6:14 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050606061430.GA6240@kroah.com \
--to=greg@kroah.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=yani.ioannou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox