public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Karol Kozimor <sziwan@hell.org.pl>
To: "Hanno Böck" <mail@hboeck.de>
Cc: randy_dunlap <rdunlap@xenotime.net>,
	acpi-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	julien.lerouge@free.fr
Subject: Re: [ACPI] Re: Kernel oops with asus_acpi module
Date: Tue, 7 Jun 2005 00:21:51 +0200	[thread overview]
Message-ID: <20050606222151.GB65@hell.org.pl> (raw)
In-Reply-To: <200506062347.10582.mail@hboeck.de>

Thus wrote Hanno Böck:
> Am Montag, 6. Juni 2005 23:32 schrieb Karol Kozimor:
> > May I see the DSDT? The Samsung P30 INIT method referenced in
> > asus_hotk_get_info() is not supposed to return anything, not even an empty
> > string. I believe the new ACPICA implicit return might be interfering.
> > Here's the relevant part of what I based the code on:

Thanks. This might also help:

--- a/drivers/acpi/asus_acpi.c	2005-04-26 00:38:20.000000000 +0200
+++ b/drivers/acpi/asus_acpi.c	2005-06-07 00:18:17.000000000 +0200
@@ -992,7 +992,7 @@
 
 	/* Samsung P30 has a device with a valid _HID whose INIT does not 
 	 * return anything. Catch this one and any similar here */
-	if (buffer.pointer == NULL) {
+	if (buffer.pointer == NULL || buffer.length == 0) {
 		if (asus_info && /* Samsung P30 */
 		    strncmp(asus_info->oem_table_id, "ODEM", 4) == 0) {
 			hotk->model = P30;

But I'd like to get the full oops with the matching asus_acpi.o file also
(might be off the list).

Best regards,

-- 
Karol 'sziwan' Kozimor
sziwan@hell.org.pl

  reply	other threads:[~2005-06-06 22:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-05 21:40 Kernel oops with asus_acpi module Hanno Böck
2005-06-06 16:50 ` randy_dunlap
     [not found] ` <200506061929.24663.mail@hboeck.de>
     [not found]   ` <20050606114531.763eec37.rdunlap@xenotime.net>
     [not found]     ` <200506062050.42632.mail@hboeck.de>
2005-06-06 20:54       ` randy_dunlap
2005-06-06 21:32         ` Karol Kozimor
2005-06-06 21:47           ` Hanno Böck
2005-06-06 22:21             ` Karol Kozimor [this message]
2005-06-07 17:46               ` [ACPI] " Hanno Böck
2005-06-07 22:16                 ` randy_dunlap
2005-06-11 12:17                   ` Karol Kozimor
2005-10-11  9:01                     ` Hanno Böck
2005-06-11 12:19                 ` Karol Kozimor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050606222151.GB65@hell.org.pl \
    --to=sziwan@hell.org.pl \
    --cc=acpi-devel@lists.sourceforge.net \
    --cc=julien.lerouge@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@hboeck.de \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox