Re: [PATCH] fix tulip suspend/resume

Benjamin Herrenschmidt
2005-06-07T04:29:20Z

> We don't support PCI bus power management, so we don't have any idea
> what the parent is doing.

Ugh ? You don't know, thus you can't assume it's working. A rule of the
device model is, once you have been suspended, you can't assume your
parent is still there and thus that you can talk to your device. On ppc
or embedded, the arch has ways to shut down clocks and/or power to
entire bus segment and that may have happened anytime.

> Also, we don't have a pci bridge driver (one
> that uses "struct pci_driver" to handle bridge resumes properly. I'm
> working on these issues.

I know, but there may be arch thingies going on anyway. So the basic
"model" of turning back the chip on is wrong.

> I also have some changes in mind for the PM
> model to make it more friendly to the power dependency problem. So in
> short, I think this is fine for now, as every other driver is doing it
> incorrectly, and in general it is working ok for suspend and resume.

No. just return IRQ_NONE. That is the only sane thing to do.

> They're all broken in this respect, and we need to gradually fix them.
> But first we need the infrastructure to make this possible.

No. That specific bit can be easily fixed for PCI drivers like that.
Just return IRQ_NONE, you shouldn't be emitting any IRQ yourself anyway.

> I haven't decided yet, but we could probably hide much of this inside
> pci_set_power_state().

No need.

> > Also, isn't that racy vs. the code in suspend() anyway ? You need to
> > make sure you program your chip not to issue any interrupt and
> > synchronize proerly, then just "ignore" (don't handle) interrupts coming
> > in as they should not be for you.
>
> Yeah, that's exactly what I had in mind. As I understand, tulip_down
> does tells the chip not to issue interrupts. Then we unregister the
> interrupt handler before powering down the device to avoid any issues
> with shared interrupts. The best way of ignoring interrupts is to
> unregister the handler. Do you still see a race condition?

Well, if we have told the chip not to issue interrupts, then it's safe
to just have the handler return IRQ_NONE... we don't even need to
unregister the handler. (That's actually equivalent to some regard).

To not be racy, the best is to synchronize though. Something like this
pseudo code:

suspend():

1) chip_disable_irq(); /* disable emission of IRQs on the chip,
* maybe do that & below in a spinlock_irq
* to make sure no other driver code path
* re-enables them
*/

2) me->sleeping = 1; /* tells the rest of the driver I'm not there
* anymore, can be some netif_* thingy.
*/

3) synchronize_irq(me->irq); /* make sure above is visible to IRQs and
* any pending one competes on another
* CPU
*/

4) pci_set_power_state(), maybe free_irq(), etc...

my_irq_handler():

if (me->sleeping)
return IRQ_NONE;

That's it.

Ben.