Re: [PATCH] fix tulip suspend/resume

Benjamin Herrenschmidt
2005-06-08T00:30:52Z

> pci_power_t pci_choose_state(struct pci_dev *dev, pm_message_t state)
> {
> if (!pci_find_capability(dev, PCI_CAP_ID_PM))
> return PCI_D0;
>
> switch (state) {
> case 0: return PCI_D0;
> case 3: return PCI_D3hot;
> default:
> printk("They asked me for state %d\n", state);
> BUG();
> }
> return PCI_D0;
> }

Gack ! I need to remember to fix that one before I change PMSG_FREEZE
definition to be different than PMSG_SUSPEND upstream.

Pavel, do you know that there are other ways to deal with errors than
just BUG()'ing all over the place ? :)

Ben.