Re: [PATCH] fix tulip suspend/resume

Karsten Keil
2005-06-09T08:27:32Z

Hi,

On Thu, Jun 09, 2005 at 02:04:02AM +0200, Pavel Machek wrote:
...
>
> > > You passed invalid argument; I see no reason why you should paper over
> > > it and risk continuing. This happens during system suspend; it is
> > > quite possible that user will not see your printk when machine powers
> > > off just after that; and remember that it will not be in syslog after
> > > resume.
> >
> > Crap. I don't think a BUG() makes any useful help neither in this place,
> > and when I locally turn PMSG_FREEZE to something sane I suddenly blow up
> > in there (and I wonder in how many other places).
>
> At least you can see & report that error... That would not be a case
> for simple printk.
>

Yes, but BUG() should not used for that, IMHO BUG() should be used only for
critical situation, in which you cannot do anything and here is danger to
lost data, I don't think this is the case here, but the BUG() will crash the
machine and so you might be loose data, which is not nice to do, for only to
request a report. Yes printk only is ignored by many people, but here are
always some, who will report it.

--
Karsten Keil
SuSE Labs
ISDN development