From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261730AbVFGFtj (ORCPT ); Tue, 7 Jun 2005 01:49:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261740AbVFGFtj (ORCPT ); Tue, 7 Jun 2005 01:49:39 -0400 Received: from cpe-24-93-172-51.neo.res.rr.com ([24.93.172.51]:5507 "EHLO neo.rr.com") by vger.kernel.org with ESMTP id S261730AbVFGFtf (ORCPT ); Tue, 7 Jun 2005 01:49:35 -0400 Date: Tue, 7 Jun 2005 01:46:04 -0400 From: Adam Belay To: Greg KH Cc: Roland Dreier , Dave Jones , Grant Grundler , tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, davem@davemloft.net Subject: Re: pci_enable_msi() for everyone? Message-ID: <20050607054604.GA8340@neo.rr.com> Mail-Followup-To: Adam Belay , Greg KH , Roland Dreier , Dave Jones , Grant Grundler , tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org, davem@davemloft.net References: <20050603224551.GA10014@kroah.com> <20050604013112.GB16999@colo.lackof.org> <20050604064821.GC13238@suse.de> <20050604070537.GB8230@colo.lackof.org> <20050604071803.GA13684@suse.de> <20050604072348.GA28293@redhat.com> <20050606230118.GD11184@suse.de> <5264wrj9l3.fsf@topspin.com> <20050607052202.GD17734@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050607052202.GD17734@suse.de> User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2005 at 10:22:03PM -0700, Greg KH wrote: > On Mon, Jun 06, 2005 at 05:26:32PM -0700, Roland Dreier wrote: > > > > davej> What if MSI support has been disabled in the bridge due to > > davej> some quirk (like the recent AMD 8111 quirk) ? Maybe the > > davej> above function should check pci_msi_enable as well ? > > > > Greg> Yes, you are correct. I said it wasn't tested :) > > > > Huh? If a host bridge doesn't support MSI, and a device below it has > > its MSI capability enabled, we're in big trouble. Because that device > > is going to send interrupt messages whether the bridge likes it or > > not. > > No, that device would never get MSI enabled on it. See the patch I > posted to make sure I didn't get it wrong... > > thanks, > > greg k-h How are we handling the case where a device has multiple MSI messages. Is any driver interaction needed for that? Will this change affect it? I haven't had a chance to look through the MSI code yet. Thanks, Adam