From: Greg KH <greg@kroah.com>
To: dtor_core@ameritech.net
Cc: Abhay Salunke <Abhay_Salunke@dell.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
matt_domsch@dell.com, Manuel Estrada Sainz <ranty@debian.org>
Subject: Re: [patch 2.6.12-rc3] modifications in firmware_class.c to support nohotplug
Date: Wed, 8 Jun 2005 09:02:44 -0700 [thread overview]
Message-ID: <20050608160244.GA1122@kroah.com> (raw)
In-Reply-To: <d120d50005060808565a7944f2@mail.gmail.com>
On Wed, Jun 08, 2005 at 10:56:19AM -0500, Dmitry Torokhov wrote:
> On 6/8/05, Abhay Salunke <Abhay_Salunke@dell.com> wrote:
> > @@ -364,6 +364,7 @@ fw_setup_class_device(struct firmware *f
> > printk(KERN_ERR "%s: class_device_create_file failed\n",
> > __FUNCTION__);
> > goto error_unreg;
> > +r
>
> What is this?
Proof he didn't test the code :(
> I think it would be better if you just have request_firmware and
> request_firmware_nowait accept timeout parameter that would override
> default timeout in firmware_class. 0 would mean use default,
> MAX_SCHED_TIMEOUT - wait indefinitely.
Yes and no. Yes in that we should have a timeout value. No in that 0
should be "forever" and we #define the current 10 second value.
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-08 16:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-08 15:17 [patch 2.6.12-rc3] modifications in firmware_class.c to support nohotplug Abhay Salunke
2005-06-08 15:56 ` Dmitry Torokhov
2005-06-08 16:02 ` Greg KH [this message]
2005-06-08 16:09 ` Dmitry Torokhov
2005-06-08 16:19 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-06-08 15:56 Abhay Salunke
2005-06-08 16:04 Abhay_Salunke
2005-06-08 16:09 ` Greg KH
2005-06-08 16:23 Abhay_Salunke
2005-06-08 16:26 ` Greg KH
2005-06-08 17:06 ` Dmitry Torokhov
2005-06-08 16:35 Abhay_Salunke
2005-06-09 21:11 Abhay_Salunke
2005-06-10 19:45 Abhay_Salunke
2005-06-10 19:57 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050608160244.GA1122@kroah.com \
--to=greg@kroah.com \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=matt_domsch@dell.com \
--cc=ranty@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox