public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: Andi Kleen <ak@suse.de>,
	linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
	Roland Dreier <roland@topspin.com>,
	Arjan van de Ven <arjan@infradead.org>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>,
	Jeff Garzik <jgarzik@pobox.com>,
	"David S. Miller" <davem@davemloft.net>,
	tom.l.nguyen@intel.com
Subject: Re: [Penance PATCH] PCI: clean up the MSI code a bit
Date: Wed, 8 Jun 2005 10:45:48 -0700	[thread overview]
Message-ID: <20050608174548.GA3725@suse.de> (raw)
In-Reply-To: <20050608171440.GD5908@colo.lackof.org>

On Wed, Jun 08, 2005 at 11:14:40AM -0600, Grant Grundler wrote:
> On Wed, Jun 08, 2005 at 03:41:09PM +0200, Andi Kleen wrote:
> > I disagree it should stay as it is. Basically you are trading
> > a bit less complexity in Infiniband now for a lot of code everywhere.
> 
> It's not just infiniband. It's tg3 and e1000 as well.

Yes, it's every device that wants to enable MSI.  So far, only one
driver that wants to enable MSI, has to handle broken devices.  And odds
are, that driver just isn't tested properly yet :)

So I stand by my decision now, it's just too complex to enable MSI for
everyone and expect drivers to disable it properly if they need to.  The
logic is just convoluted (see the patch for details.)  As proof, I got
it completly wrong the first time, and I'm still not sure that I got it
correct after working on this for a while. :)

In the end, the pci_enable/pci_disable interface is the way to go.

thanks,

greg k-h

  reply	other threads:[~2005-06-08 17:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-08  6:35 [Penance PATCH] PCI: clean up the MSI code a bit Greg KH
2005-06-08 13:41 ` Andi Kleen
2005-06-08 17:14   ` Grant Grundler
2005-06-08 17:45     ` Greg KH [this message]
2005-06-09 14:15       ` Andi Kleen
2005-06-09 23:49         ` Stefan Smietanowski
  -- strict thread matches above, loose matches on Subject: below --
2005-06-08 17:34 Nguyen, Tom L
2005-06-10  0:12 Nguyen, Tom L
2005-06-10 15:55 ` Stefan Smietanowski
2005-06-13 16:15 Nguyen, Tom L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050608174548.GA3725@suse.de \
    --to=gregkh@suse.de \
    --cc=ak@suse.de \
    --cc=andrew.vasquez@qlogic.com \
    --cc=arjan@infradead.org \
    --cc=davem@davemloft.net \
    --cc=grundler@parisc-linux.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=roland@topspin.com \
    --cc=tom.l.nguyen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox