public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
	ak@suse.de
Subject: [patch 05/09] x86_64: Fix ptrace boundary check
Date: Wed, 8 Jun 2005 17:08:11 -0700	[thread overview]
Message-ID: <20050609000811.GL13152@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050608234637.GG13152@shell0.pdx.osdl.net>

Don't allow accesses below register frame in ptrace

There was a "off by one quad word" error in there. 

Found and fixed by John Blackwood

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Chris Wright <chrisw@osdl.org>

 arch/x86_64/kernel/ptrace.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Index: release-2.6.11/arch/x86_64/kernel/ptrace.c
===================================================================
--- release-2.6.11.orig/arch/x86_64/kernel/ptrace.c
+++ release-2.6.11/arch/x86_64/kernel/ptrace.c
@@ -252,7 +252,7 @@ asmlinkage long sys_ptrace(long request,
 			break;
 
 		switch (addr) { 
-		case 0 ... sizeof(struct user_regs_struct):
+		case 0 ... sizeof(struct user_regs_struct) - sizeof(long):
 			tmp = getreg(child, addr);
 			break;
 		case offsetof(struct user, u_debugreg[0]):
@@ -297,7 +297,7 @@ asmlinkage long sys_ptrace(long request,
 			break;
 
 		switch (addr) { 
-		case 0 ... sizeof(struct user_regs_struct): 
+		case 0 ... sizeof(struct user_regs_struct) - sizeof(long):
 			ret = putreg(child, addr, data);
 			break;
 		/* Disallows to set a breakpoint into the vsyscall */

  parent reply	other threads:[~2005-06-09  0:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-08 23:46 [00/09] -stable review Chris Wright
2005-06-08 23:52 ` [patch 01/09] try_to_unmap_cluster() passes out-of-bounds pte to pte_unmap() Chris Wright
2005-06-08 23:55 ` [patch 02/09] [NETFILTER]: Fix deadlock with ip_queue and tcp local input path Chris Wright
2005-06-09  0:00 ` [patch 03/09] fix hfsplus oops, hfs and hfsplus leak Chris Wright
2005-06-09  0:04 ` [patch 04/09] x86_64: avoid SMP boot up race Chris Wright
2005-09-14  3:13   ` Horms
2005-09-14  6:29     ` Chris Wright
2005-06-09  0:08 ` Chris Wright [this message]
2005-06-09  0:14 ` [patch 06/09] Fix for bttv driver (v0.9.15) for Leadtek WinFast VC100 XP capture cards Chris Wright
2005-06-09  0:18 ` [patch 07/09] ext3: fix log_do_checkpoint() assertion failure Chris Wright
2005-06-09  0:21 ` [patch 08/09] [BRIDGE]: prevent bad forwarding table updates Chris Wright
2005-06-09  0:24 ` [patch 09/09] [PKT_SCHED]: netem: duplication fix Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050609000811.GL13152@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=chuckw@quantumlinux.com \
    --cc=jmforbes@linuxtx.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=stable@kernel.org \
    --cc=torvalds@osdl.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox