From: Greg KH <greg@kroah.com>
To: Rui Sousa <rui.sousa@laposte.net>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
dmitry pervushin <dpervushin@ru.mvista.com>,
linux-kernel@vger.kernel.org,
lm-sensors <lm-sensors@lm-sensors.org>
Subject: Re: [RFC] SPI core
Date: Thu, 9 Jun 2005 00:15:23 -0700 [thread overview]
Message-ID: <20050609071523.GE22729@kroah.com> (raw)
In-Reply-To: <1117717356.5794.9.camel@localhost.localdomain>
On Thu, Jun 02, 2005 at 03:02:35PM +0200, Rui Sousa wrote:
> Hi Greg,
>
> On Wed, 2005-06-01 at 21:51 -0700, Greg KH wrote:
> > On Thu, Jun 02, 2005 at 12:06:55AM -0400, Mark M. Hoffman wrote:
> > > * Greg KH <greg@kroah.com> [2005-05-31 16:32:15 -0700]:
> > > > This code is _very_ close to just a copy of the i2c core code. Why
> > > > duplicate it and not work with the i2c people instead?
> > >
> > > It was discussed briefly on the lm-sensors mailing list [1]. I didn't
> > > reply at the time, but I do agree that SPI and I2C/SMBus are different
> > > enough to warrant independent subsystems.
> >
> > Independant is fine. But direct copies, including making the same
> > mistakes (i2c dev interface, i2c driver model mess) isn't :)
>
> I have also worked on a(nother) SPI layer implementation. Like Dmitry, I
> ended up following closely the i2c implementation, so, I'm curious to
> know more details on what you call "i2c driver model mess".
The fact that the i2c drivers are not really true "drivers" in the
driver model. We bind them by hand to the device and then register the
device with the core. That isn't a nice thing to do...
Also the sysfs representation of the sensor stuff is tied to the i2c
sysfs code very tightly, which isn't good for other types of sensors.
It should be in the class portion of sysfs, and the recent hwmon patches
are moving it in that direction.
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-09 7:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-31 16:09 [RFC] SPI core dmitry pervushin
2005-05-31 18:33 ` randy_dunlap
2005-05-31 20:44 ` Alexey Dobriyan
2005-05-31 21:41 ` NZG
2005-05-31 23:20 ` Greg KH
2005-05-31 23:32 ` Greg KH
2005-06-02 4:06 ` Mark M. Hoffman
2005-06-02 4:51 ` Greg KH
2005-06-02 13:02 ` Rui Sousa
2005-06-09 7:15 ` Greg KH [this message]
2005-06-09 10:39 ` Hinko Kocevar
2005-06-09 15:41 ` Lee Revell
2005-06-02 10:09 ` dmitry pervushin
2005-06-09 12:33 ` Pekka Enberg
2005-06-09 16:19 ` Alexey Dobriyan
2005-06-09 17:41 ` Pekka Enberg
-- strict thread matches above, loose matches on Subject: below --
2005-06-01 1:19 David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050609071523.GE22729@kroah.com \
--to=greg@kroah.com \
--cc=dpervushin@ru.mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=rui.sousa@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox