public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Adam Belay <ambx1@neo.rr.com>,
	matthieu castet <castet.matthieu@free.fr>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: PNP parallel&serial ports: module reload fails (2.6.11)?
Date: Thu, 9 Jun 2005 22:16:57 +0100	[thread overview]
Message-ID: <20050609221657.C14513@flint.arm.linux.org.uk> (raw)
In-Reply-To: <42A8AFA5.3090703@tls.msk.ru>; from mjt@tls.msk.ru on Fri, Jun 10, 2005 at 01:07:49AM +0400

On Fri, Jun 10, 2005 at 01:07:49AM +0400, Michael Tokarev wrote:
> And this 8250 vs 8250_pnp (and 8250_pci etc, but
> especially 8250_pnp as it is the most interesting one).
> When loading 8250 alone (note that 8250_pnp depends
> on 8250, so 8250 gets loaded first), it detects standard
> serial port(s) just fine.  8250_pnp "redetects" them again
> (see first `modprobe 8250_pnp' above: each ttySN line
> gets repeated twice). But when unloading 8250_pnp, both
> standard ttySNs are deactivated, even when 8250 is still
> here.  More, when unloading both 8250_pnp and 8250, and
> loading *only* 8250 after that, no standard ports gets
> detected until 8250_pnp will be loaded (as the devices
> are disabled, and 8250_pnp re-enables them).  Ie, this
> whole stuff does not look right.  Probably a nitpicking,
> but a bit.. strange.  Probably if 8250_pnp will stop
> deactivating the devices (as per above), everything will
> look ok here too.  Or, maybe it's a good idea to just
> combine 8250 and 8250_pnp modules (and maybe 8250_serial
> too), esp, since the latter is very small anyway ?

The idea is that 8250 handles those serial ports.  8250_pnp, 8250_pci
and 8250_acorn etc are all probe modules which register with 8250,
know how the bus type works and tells 8250 where the ports are.

It's a cleaner design rather than stuffing multiple bus types into one
driver.

The reason that 8250 first detects your ports is that they're found
via the legacy method which is independent of PnP.  As you correctly
sumise, when you unload 8250_pnp, it disables the device so when you
re-load 8250, it's unable to detect your ports using the legacy method.

But the legacy method needs to continue to exist for systems which
don't have PnP enabled.

So, the above behaviour is completely expected and isn't a sign of
a deeper problem.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

  reply	other threads:[~2005-06-09 21:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-02 22:24 Re:PNP parallel&serial ports: module reload fails (2.6.11)? castet.matthieu
2005-06-03  0:18 ` PNP " Michael Tokarev
2005-06-03  5:58   ` matthieu castet
2005-06-05 10:14   ` matthieu castet
2005-06-05 10:27   ` matthieu castet
2005-06-06 15:01     ` Michael Tokarev
2005-06-06 15:43       ` castet.matthieu
2005-06-06 21:18       ` Adam Belay
2005-06-06 22:43         ` Michael Tokarev
2005-06-08  9:52           ` Adam Belay
2005-06-08 20:29             ` Michael Tokarev
2005-06-08 23:52               ` Adam Belay
2005-06-09 21:07                 ` Michael Tokarev
2005-06-09 21:16                   ` Russell King [this message]
2005-06-10 16:01                     ` Bjorn Helgaas
2005-06-10 16:20                       ` Dmitry Torokhov
2005-06-10 16:26                         ` Bjorn Helgaas
2005-06-10 16:30                       ` Russell King
2005-06-14 19:40                   ` Adam Belay
  -- strict thread matches above, loose matches on Subject: below --
2005-05-31 23:01 Michael Tokarev
2005-06-01  5:04 ` Andrew Morton
2005-06-01 15:20   ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050609221657.C14513@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=ambx1@neo.rr.com \
    --cc=castet.matthieu@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjt@tls.msk.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox