From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Cc: nsankar@broadcom.com
Subject: [PATCH] PCI: MSI functionality broken on Serverworks GC chipset
Date: Thu, 9 Jun 2005 15:21:33 -0700 [thread overview]
Message-ID: <20050609222133.GB12580@kroah.com> (raw)
In-Reply-To: <20050609222033.GA12580@kroah.com>
[PATCH] PCI: MSI functionality broken on Serverworks GC chipset
MSI functionality is broken on the GC_LE x86 chipset that Serverworks
developed and that is being used in various platforms today. Broadcom is
going to push out to the kernel MSI enabled Gigabit drivers (in the very
near future), and we would like to make sure that MSI does not get
enabled on any platforms using the GC_LE chipset (device id 0x17).
Following the AMD 8131 example, I am including a patch to disable MSI
functionality when a GCNB_LE is detected. Please let me know if there
are any issues with this. This is a permanent fix for this chipset, as
the hardware will not be updated.
Signed-off-by: Narendra Sankar <nsankar@broadcom.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
commit 1e06276704c101bd1ae7b62879faaffcd7496a3e
tree 0b983e8000ed7f57d189f68097a6e78ad5c33488
parent 76854ceac3ef3408ab9a50a2521147fb14779f58
author Narendra Sankar <nsankar@broadcom.com> Fri, 06 May 2005 14:12:05 -0700
committer Greg Kroah-Hartman <gregkh@suse.de> Thu, 09 Jun 2005 17:04:30 -0700
drivers/pci/quirks.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -456,6 +456,12 @@ static void __init quirk_amd_8131_ioapic
}
DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_AMD_8131_APIC, quirk_amd_8131_ioapic );
+static void __init quirk_svw_msi(struct pci_dev *dev)
+{
+ pci_msi_quirk = 1;
+ printk(KERN_WARNING "PCI: MSI quirk detected. pci_msi_quirk set.\n");
+}
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_SERVERWORKS, PCI_DEVICE_ID_SERVERWORKS_GCNB_LE, quirk_svw_msi );
#endif /* CONFIG_X86_IO_APIC */
next prev parent reply other threads:[~2005-06-09 22:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-09 22:20 [GIT PATCH] Another PCI fix for 2.6.12-rc6 Greg KH
2005-06-09 22:21 ` Greg KH [this message]
2005-06-09 22:31 ` [PATCH] PCI: MSI functionality broken on Serverworks GC chipset David S. Miller
2005-06-09 22:32 ` [GIT PATCH] Another PCI fix for 2.6.12-rc6 David S. Miller
2005-06-09 22:48 ` Narendra Sankar
2005-06-09 22:51 ` David S. Miller
2005-06-09 22:56 ` Narendra Sankar
2005-06-09 22:55 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050609222133.GB12580@kroah.com \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=nsankar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox