From: Ingo Molnar <mingo@elte.hu>
To: Luca Falavigna <dktrkranz@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Real-Time Preemption, using msecs_to_jiffies() instead of HZ
Date: Sat, 11 Jun 2005 15:32:46 +0200 [thread overview]
Message-ID: <20050611133246.GA29414@elte.hu> (raw)
In-Reply-To: <42A9C2E0.30002@gmail.com>
* Luca Falavigna <dktrkranz@gmail.com> wrote:
> I was looking at kernel/softlookup.c when I noticed you used HZ in order to get
> a 10-second delay:
>
> void softlockup_tick(struct pt_regs *regs)
> {
> ...
> if (time_after(jiffies, timestamp + 10*HZ)) {
> ...
> }
oops, indeed. (i've also forwarded your patch to akpm, as the softlockup
patch is included in -mm too)
> I created this small patch (built against version
> 2.6.12-rc6-V0.7.48-05) which does use of msecs_to_jiffies() to get a
> correct behaviour with every platform. Similarly I modified function
> watchdog and kernel/irq/autoprobe.c file (probe_irq_on function).
>
> Here is the patch:
> ++ msleep(msecs_to_jiffies(20));
> ++ msleep(msecs_to_jiffies(100));
> ++ msleep_interruptible(msecs_to_jiffies(1000));
actually, this should be msleep(20/100/1000). I've fixed these in my
tree.
Ingo
next prev parent reply other threads:[~2005-06-11 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-10 16:42 [PATCH] Real-Time Preemption, using msecs_to_jiffies() instead of HZ Luca Falavigna
2005-06-11 13:32 ` Ingo Molnar [this message]
2005-06-13 2:10 ` Luca Falavigna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050611133246.GA29414@elte.hu \
--to=mingo@elte.hu \
--cc=dktrkranz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox