public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* unexport and static __mntput()
@ 2005-06-09 11:31 Coywolf Qi Hunt
  2005-06-09 21:26 ` Mike Waychison
  2005-06-11 19:28 ` Adrian Bunk
  0 siblings, 2 replies; 3+ messages in thread
From: Coywolf Qi Hunt @ 2005-06-09 11:31 UTC (permalink / raw)
  To: linux-kernel; +Cc: bunk

Hello,

I don't see any reasons that modules should call __mntput.
And it's only called by mntput(). Or anyone knows any outer code depends on it?

Adrian, a patch unexport and static it?

-- 
Coywolf Qi Hunt
http://ahbl.org/~coywolf/

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: unexport and static __mntput()
  2005-06-09 11:31 unexport and static __mntput() Coywolf Qi Hunt
@ 2005-06-09 21:26 ` Mike Waychison
  2005-06-11 19:28 ` Adrian Bunk
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Waychison @ 2005-06-09 21:26 UTC (permalink / raw)
  To: Coywolf Qi Hunt; +Cc: bunk, linux-kernel

Coywolf Qi Hunt wrote:
> Hello,
> 
> I don't see any reasons that modules should call __mntput.
> And it's only called by mntput(). Or anyone knows any outer code depends on it?
> 
> Adrian, a patch unexport and static it?
> 

It's used indirectly by autofs, autofs4 and nfsd.

Mike Waychison

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: unexport and static __mntput()
  2005-06-09 11:31 unexport and static __mntput() Coywolf Qi Hunt
  2005-06-09 21:26 ` Mike Waychison
@ 2005-06-11 19:28 ` Adrian Bunk
  1 sibling, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2005-06-11 19:28 UTC (permalink / raw)
  To: Coywolf Qi Hunt; +Cc: linux-kernel

On Thu, Jun 09, 2005 at 07:31:41PM +0800, Coywolf Qi Hunt wrote:
> Hello,
> 
> I don't see any reasons that modules should call __mntput.
> And it's only called by mntput(). Or anyone knows any outer code depends on it?
> 
> Adrian, a patch unexport and static it?

Besides it being wrong (as Mike Waychison already explained), why can't 
you make patches yourself? It's not that I had any special position in 
kernel development...

> Coywolf Qi Hunt

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-06-11 19:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-09 11:31 unexport and static __mntput() Coywolf Qi Hunt
2005-06-09 21:26 ` Mike Waychison
2005-06-11 19:28 ` Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox