public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-hotplug-devel@lists.sourceforge.net,
	Greg KH <gregkh@suse.de>, Vojtech Pavlik <vojtech@suse.cz>,
	Kay Sievers <kay.sievers@vrfy.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: Input sysbsystema and hotplug
Date: Tue, 14 Jun 2005 02:52:41 -0500	[thread overview]
Message-ID: <200506140252.42306.dtor_core@ameritech.net> (raw)
In-Reply-To: <42AE8A9E.5040406@suse.de>

On Tuesday 14 June 2005 02:43, Hannes Reinecke wrote:
> Dmitry Torokhov wrote:
> > 	 
> Hmm. I don't like it very much as it mixes two different types of
> devices (class devices and subclasses) into one directory.
> 

If one could come up with a good name to group inputX under I think
it will be OK. We'd have XXX, mouse, joystick, event, ... as subclasses
and all class_devices will be on level below. OTOH input_devs are parents
for mice, joysticks etc so they might be on the higher level.

> I think it's cleaner to have two distinct class device types
> (one for input_dev and one for input).
> 

I actually detest this practice:

[dtor@core ~]$ ls /sys/class/
firmware     ieee1394       ieee1394_protocol  mem   pci_bus        sound  usb_host
graphics     ieee1394_host  input              misc  pcmcia_socket  tty    vc
i2c-adapter  ieee1394_node  input_dev          net   printer        usb
[dtor@core ~]$

dtor@anvil ~]$ ls /sys/class/
cpuid     i2c-adapter  ieee1394_host      input  msr      printer      sound  usb_host
firmware  i2c-dev      ieee1394_node      mem    net      scsi_device  tty    vc
graphics  ieee1394     ieee1394_protocol  misc   pci_bus  scsi_host    usb    video4linux
[dtor@anvil ~]$

Firewire has 4 classes on the uppper level, I2C, USB, SCSI and Input got
2 each. It would be much nicer IMHO if we merge them into trees of classes
with poarent class actually defining subsystem.  

> subclasses for the input class devices are a neat idea; but I fear the
> hotplug event name will change for each subclass device ('input' will
> become eg 'mouse'), so we again have to change all hotplug handlers.
> And I don't see an easy solution for that ...
>

We could have parent class define agent/subsystem name for all its children.

-- 
Dmitry

  reply	other threads:[~2005-06-14  7:52 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200506131607.51736.dtor_core@ameritech.net>
2005-06-13 21:26 ` Input sysbsystema and hotplug Kay Sievers
2005-06-13 21:38   ` Dmitry Torokhov
2005-06-13 22:17     ` Greg KH
2005-06-14  6:14       ` Dmitry Torokhov
2005-06-13 21:58   ` Dmitry Torokhov
2005-06-13 22:05     ` Dmitry Torokhov
2005-06-13 22:15       ` Greg KH
2005-06-14  6:08         ` Dmitry Torokhov
2005-06-13 22:21       ` Kay Sievers
2005-06-14  7:32       ` Hannes Reinecke
2005-06-14  7:42         ` Dmitry Torokhov
2005-06-14  7:47           ` Hannes Reinecke
2005-06-14  7:56             ` Dmitry Torokhov
2005-06-19 14:46             ` David Brownell
2005-06-13 22:16 ` Greg KH
2005-06-14  4:26   ` Dmitry Torokhov
2005-06-14  6:21   ` Jon Smirl
2005-06-14  6:38     ` Greg KH
2005-06-14 13:41       ` Jon Smirl
2005-06-14 15:02       ` Jon Smirl
2005-06-14 18:16         ` Dmitry Torokhov
2005-06-14  7:43 ` Hannes Reinecke
2005-06-14  7:52   ` Dmitry Torokhov [this message]
2005-06-14  8:00     ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506140252.42306.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=gregkh@suse.de \
    --cc=hare@suse.de \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-hotplug-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox