Re: [PATCH] [1/2] IDE CD reports current speed

[Jens Axboe <axboe@suse.de>]

On Tue, Jun 14 2005, Eric Piel wrote:
> Hello,
> 
> The current ide-cd driver reports the CDROM speed (as found in 
> /proc/sys/dev/cdrom/info) as the current speed when loading the driver. 
> Changing the speed of the cdrom drive (by "eject -x" for instance) 
> doesn't update the speed reported by the kernel. Updating the info could 
> be valuable for the user as it's the only way to know if the drive 
> accepted the request or discarded it. It could even be used to list all 
> the available speeds of the drive.
> 
> The attached patch modifies the ide-cd driver so that after every speed 
> change request the new speed is updated. Please note that the actual 
> modification is very little but I had to touch quite a few lines in 
> order to avoid to pre-declare the sub-functions.
> 
> Please, let me know if that sounds a good behaviour for the CDROM 
> interface. I hope you apply :-)

Looks sane, thanks.

-- 
Jens Axboe