Re: [PATCH 2/2] lzma support: lzma compressed kernel image

[Christian Leber <christian@leber.de>]

On Mon, Jun 13, 2005 at 08:10:25PM -0600, Frank Sorenson wrote:

> patches appear to work as advertised.

I don't like the moving of the initrd, but i don't know another way to
get it working otherwise.

> lzma reduced my kernel by
> approximately 25%, so I'd say it looks promising.

25%? i would have expected a smaller saving

> I think one or more of the following ought to happen:
> - - Modify the help text in the Kconfig option to show people how to
> obtain, compile, and install lzma (and warn them they'll need to install
> it).

How to obtain should be enough, i'll add it.

> - - Detect that the lzma application isn't present, and fall back to gzip
> (with a warning) if lzma fails.

No.
If you select lzma you have to have it, you also don't download a
compiler when somebody tries to compile the kernel without a compiler.

> - - If we can embed the decompressor into the boot-time kernel, can't we
> put a compressor into the kernel source, and avoid the need for the
> external program?

How do think will people react to a hundreds of kb sized C++ patch that
is not - i repeat - NOT in proper coding style?


Christian Leber

-- 
http://www.nosoftwarepatents.com