Re: [PATCH 0/4] new timeofday-based soft-timer subsystem

Nishanth Aravamudan
2005-06-14T17:00:30Z

On 13.06.2005 [20:46:55 -0700], Nishanth Aravamudan wrote:
> On 08.06.2005 [20:11:42 -0700], john stultz wrote:
> > Hey Everyone,
> > I'm heading out on vacation until Monday, so I'm just re-spinning my
> > current tree for testing. If there's no major issues on Monday, I'll re-
> > diff against Andrew's tree and re-submit the patches for inclusion.
>
> Here is an update of my soft-timer rework to John's latest patches. I
> have made some major changes in this revision. I would still greatly
> appreciate any comments.

<snip>

> Notes / Blocking Issues:

<snip>

> NUMA-Q is definitely broken with my patch, but not NUMA itself.
> Honestly not sure why, but timeofday seems to also be broken on
> NUMA-Q -- it sets up the TSC as the timesource, even though it
> shouldn't be (booting with notsc on NUMA-Qs seems to fix the
> problem for John's patches, at least).

Hrm, I just tried the same emulation on NUMA-Q that I did for ppc64:

inline do_monotonic_clock()
{
return jiffies_to_nsecs(jiffies - INITIAL_JIFFIES);
}

and kernbench ran ok with just my patches on top of 2.6.12-rc6-git5. So,
I think -- not positive, admittedly, the problem may be with John's
patches on NUMA-Q, maybe even just some of the timesources.

Thanks,
Nish