Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Greg KH
2005-05-19T14:39:38Z

On Thu, May 19, 2005 at 07:03:17AM -0500, Abhay_Salunke@Dell.com wrote:
> > On Wed, May 18, 2005 at 01:13:42PM -0500, Abhay Salunke wrote:
> > > This is a resubmit of the patch after incorporating all the inputs
> > > from revieweres. This also has a fix where the packets were leaked in
> > > the function create_packet line#227.
> >
> > You did not address the issues I had with your use of binary sysfs files
> > for all file types. Please fix that up.
> >
> > Also, what's wrong with using the existing firmware interface in the
> > kernel?
> >
> I am working on it; just wanted to address all the cosmetic issues
> first.

That is not what you stated above, hence my response. Next time, please
be clearer.

greg k-h