RE: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Abhay_Salunke
2005-06-17T14:55:41Z

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Thursday, June 16, 2005 1:52 PM
> To: Salunke, Abhay
> Cc: linux-kernel@vger.kernel.org; Andrew Morton; Dmitry Torokhov;
Domsch,
> Matt
> Subject: Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new
Dell
> BIOS update driver
>
> On Wed, Jun 15, 2005 at 12:59:46PM -0500, Abhay Salunke wrote:
> > +static struct device rbu_device_mono;
> > +static struct device rbu_device_packet;
> > +static struct device rbu_device_cancel;
>
> You should never create a struct device on the stack. Lots of bad
> things can happen (including not having a release function for them.)
>
they are not declared inside any function; can they be on stack?
> Why not just point to the cpu device, or some other platform or system
> device?
>
Not sure what these devices are for and didn't want to mess with them.>

Thanks
Abhay