Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Andreas Henriksson
2005-06-03T12:26:46Z

On Fri, Jun 03, 2005 at 01:58:48AM +0200, Marcel Holtmann wrote:

>
> > + if ((rc = fill_last_packet(data, length)) != 0)
>
> Use "if (!(rc = fill_last_packet(data, length)))".
>

Even better like this?

rc = fill_last_packet(data, length);
if (!rc)

>
> > + if ( rc == 0 )
>
> Spaces.
>

Plus use: if (!rc)

Regards,
Andreas Henriksson