Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Jesper Juhl
2005-06-05T21:51:12Z

On 6/3/05, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi Abhay,
>
> > Resubmitting after cleaning up spaces/tabs etc...
>
> and now starting with the coding style nitpicking ;)
>
[snip]
> > + if (pbuf != NULL) {
>
> Make it "if (!pbuf)",
>
[snip]

You want to make it "if (pbuf)" otherwise you'd be changing the logic.

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html