Re: [PATCH] pci: don't override drv->shutdown unconditionally

[Greg KH <gregkh@suse.de>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 891 bytes --]

On Fri, Jun 17, 2005 at 08:30:57PM +0200, Christoph Hellwig wrote:
> There are many drivers that have been setting the generic driver
> model­level shutdown callback, and pci thus must not override it.
> 
> Without this patch we can have really bad data loss on various
> raid controllers.

Without the kexec patch?

So, why are these drivers setting the shutdown function in the first
place if they don't want it to be called?  My change finally enabled
this call, which is what the driver authors expected in the first place.

Without the change I made, the same data loss would be had as drivers
never know that the box is going down.

The fact that a few drivers never tested their shutdown calls is no
reason to penalize the whole kernel.

So, no, I do not want this change in, the drivers should be fixed
properly.

Care to point me to any drivers that need fixing?

thanks,

greg k-h