From: Christoph Hellwig <hch@lst.de>
To: Greg KH <gregkh@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: don't override drv->shutdown unconditionally
Date: Fri, 17 Jun 2005 20:51:04 +0200 [thread overview]
Message-ID: <20050617185104.GA21256@lst.de> (raw)
In-Reply-To: <20050617184914.GA22107@suse.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 701 bytes --]
On Fri, Jun 17, 2005 at 11:49:14AM -0700, Greg KH wrote:
> On Fri, Jun 17, 2005 at 08:30:57PM +0200, Christoph Hellwig wrote:
> > There are many drivers that have been setting the generic driver
> > modellevel shutdown callback, and pci thus must not override it.
> >
> > Without this patch we can have really bad data loss on various
> > raid controllers.
>
> Without the kexec patch?
On shutdown. I don't know why you're talking about kexec here.
> So, why are these drivers setting the shutdown function in the first
> place if they don't want it to be called?
They _do_ want it called. They set the driver-model level one because
there hasn't been a pci-level one until a few years ago.
next prev parent reply other threads:[~2005-06-17 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-17 18:30 [PATCH] pci: don't override drv->shutdown unconditionally Christoph Hellwig
2005-06-17 18:49 ` Greg KH
2005-06-17 18:51 ` Christoph Hellwig [this message]
2005-06-17 18:53 ` Greg KH
2005-06-17 19:01 ` Greg KH
2005-06-17 19:34 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2005-06-17 19:25 [PATCH] PCI: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050617185104.GA21256@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox