From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S262059AbVFQSzg@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S262059AbVFQSzg (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 17 Jun 2005 14:55:36 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262064AbVFQSyk
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 17 Jun 2005 14:54:40 -0400
Received: from lyle.provo.novell.com ([137.65.81.174]:39607 "EHLO
	lyle.provo.novell.com") by vger.kernel.org with ESMTP
	id S262060AbVFQSx0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jun 2005 14:53:26 -0400
Date: Fri, 17 Jun 2005 11:53:11 -0700
From: Greg KH <gregkh@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: don't override drv->shutdown unconditionally
Message-ID: <20050617185311.GC22107@suse.de>
References: <20050617183057.GA20966@lst.de> <20050617184914.GA22107@suse.de> <20050617185104.GA21256@lst.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=unknown-8bit
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20050617185104.GA21256@lst.de>
User-Agent: Mutt/1.5.8i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 17, 2005 at 08:51:04PM +0200, Christoph Hellwig wrote:
> On Fri, Jun 17, 2005 at 11:49:14AM -0700, Greg KH wrote:
> > On Fri, Jun 17, 2005 at 08:30:57PM +0200, Christoph Hellwig wrote:
> > > There are many drivers that have been setting the generic driver
> > > model­level shutdown callback, and pci thus must not override it.
> > > 
> > > Without this patch we can have really bad data loss on various
> > > raid controllers.
> > 
> > Without the kexec patch?
> 
> On shutdown.  I don't know why you're talking about kexec here.

Because of the previous kexec comments on the linux-scsi list.

> > So, why are these drivers setting the shutdown function in the first
> > place if they don't want it to be called? 
> 
> They _do_ want it called.  They set the driver-model level one because
> there hasn't been a pci-level one until a few years ago.

So they are setting two callbacks?  Have a pointer to any driver that
does this?

thanks,

greg k-h