From: Greg KH <gregkh@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: don't override drv->shutdown unconditionally
Date: Fri, 17 Jun 2005 12:34:25 -0700 [thread overview]
Message-ID: <20050617193425.GA22570@suse.de> (raw)
In-Reply-To: <20050617190133.GA22280@suse.de>
On Fri, Jun 17, 2005 at 12:01:33PM -0700, Greg KH wrote:
> On Fri, Jun 17, 2005 at 11:53:11AM -0700, Greg KH wrote:
> > On Fri, Jun 17, 2005 at 08:51:04PM +0200, Christoph Hellwig wrote:
> > > They _do_ want it called. They set the driver-model level one because
> > > there hasn't been a pci-level one until a few years ago.
> >
> > So they are setting two callbacks? Have a pointer to any driver that
> > does this?
>
> Ok, I see the drivers that do this now, they should be fixed. I'll make
> up a patch now to do that.
Hm, that's too big of a patch for 2.6.12 this late in the game, I've
forwarded your patch on to Linus with an added comment. I'll fix up the
drivers for 2.6.13 and then change the pci core back.
Sorry for the confusion, you were right.
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-17 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-17 18:30 [PATCH] pci: don't override drv->shutdown unconditionally Christoph Hellwig
2005-06-17 18:49 ` Greg KH
2005-06-17 18:51 ` Christoph Hellwig
2005-06-17 18:53 ` Greg KH
2005-06-17 19:01 ` Greg KH
2005-06-17 19:34 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-17 19:25 [PATCH] PCI: " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050617193425.GA22570@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox