From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262076AbVFQTfX (ORCPT ); Fri, 17 Jun 2005 15:35:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262081AbVFQTfW (ORCPT ); Fri, 17 Jun 2005 15:35:22 -0400 Received: from lyle.provo.novell.com ([137.65.81.174]:37049 "EHLO lyle.provo.novell.com") by vger.kernel.org with ESMTP id S262080AbVFQTek (ORCPT ); Fri, 17 Jun 2005 15:34:40 -0400 Date: Fri, 17 Jun 2005 12:34:25 -0700 From: Greg KH To: Christoph Hellwig Cc: akpm@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pci: don't override drv->shutdown unconditionally Message-ID: <20050617193425.GA22570@suse.de> References: <20050617183057.GA20966@lst.de> <20050617184914.GA22107@suse.de> <20050617185104.GA21256@lst.de> <20050617185311.GC22107@suse.de> <20050617190133.GA22280@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050617190133.GA22280@suse.de> User-Agent: Mutt/1.5.8i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 17, 2005 at 12:01:33PM -0700, Greg KH wrote: > On Fri, Jun 17, 2005 at 11:53:11AM -0700, Greg KH wrote: > > On Fri, Jun 17, 2005 at 08:51:04PM +0200, Christoph Hellwig wrote: > > > They _do_ want it called. They set the driver-model level one because > > > there hasn't been a pci-level one until a few years ago. > > > > So they are setting two callbacks? Have a pointer to any driver that > > does this? > > Ok, I see the drivers that do this now, they should be fixed. I'll make > up a patch now to do that. Hm, that's too big of a patch for 2.6.12 this late in the game, I've forwarded your patch on to Linus with an added comment. I'll fix up the drivers for 2.6.13 and then change the pci core back. Sorry for the confusion, you were right. thanks, greg k-h