public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: "Martin J. Bligh" <mbligh@mbligh.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: 2.6.12-mm1 compile failure on PPC64
Date: Mon, 20 Jun 2005 17:33:22 +0200	[thread overview]
Message-ID: <20050620153322.GA4874@elte.hu> (raw)
In-Reply-To: <191640000.1119281438@[10.10.2.4]>


* Martin J. Bligh <mbligh@mbligh.org> wrote:

> kernel/built-in.o(.init.text+0x440): In function `.sched_cacheflush':
> : undefined reference to `.cacheflush'
> make: *** [.tmp_vmlinux1] Error 1
> 06/20/05-01:28:25 Build the kernel. Failed rc = 2
> 06/20/05-01:28:25 build: kernel build Failed rc = 1
> 06/20/05-01:28:25 command complete: (2) rc=126
> Failed and terminated the run
>  Fatal error, aborting autorun
> 
> Works with some configs, but not this one:
> 
> http://ftp.kernel.org/pub/linux/kernel/people/mbligh/config/abat/p570
> 
> I'm guessing :
> 
> scheduler-cache-hot-autodetect.patch

the patch below (from akpm) should fix this:

From: Andrew Morton <akpm@osdl.org>

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 kernel/sched.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN kernel/sched.c~scheduler-cache-hot-autodetect-cacheflush-fix kernel/sched.c
--- 25/kernel/sched.c~scheduler-cache-hot-autodetect-cacheflush-fix	2005-06-18 08:38:26.000000000 -0600
+++ 25-akpm/kernel/sched.c	2005-06-18 08:38:43.000000000 -0600
@@ -5288,7 +5288,7 @@ __init static void sched_cacheflush(void
 	asm ("wbinvd");
 #elif defined(CONFIG_IA64)
 	ia64_sal_cache_flush(1); // what argument does d/cache flush?
-#elif defined(CONFIG_PPC64) || defined(CONFIG_PPC)
+#elif (defined(CONFIG_PPC64) || defined(CONFIG_PPC)) && defined(CONFIG_XMON)
 	cacheflush();
 #else
 # warning implement sched_cacheflush()! Calibration results may be unreliable.
_

  reply	other threads:[~2005-06-20 15:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-20 15:30 2.6.12-mm1 compile failure on PPC64 Martin J. Bligh
2005-06-20 15:33 ` Ingo Molnar [this message]
2005-06-20 20:15   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620153322.GA4874@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@mbligh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox