* [patch 4/4] arm/cpu-sa1110: replace schedule_timeout() with msleep()
@ 2005-03-05 22:41 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-03-05 22:41 UTC (permalink / raw)
To: rmk; +Cc: linux-kernel, domen, nacc
Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. Neither signals nor wait-queue events are important at this
point in the code, I believe.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
kj-domen/arch/arm/mach-sa1100/cpu-sa1110.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
diff -puN arch/arm/mach-sa1100/cpu-sa1110.c~msleep-arch_arm_mach-sa1100_cpu-sa1110 arch/arm/mach-sa1100/cpu-sa1110.c
--- kj/arch/arm/mach-sa1100/cpu-sa1110.c~msleep-arch_arm_mach-sa1100_cpu-sa1110 2005-03-05 16:10:43.000000000 +0100
+++ kj-domen/arch/arm/mach-sa1100/cpu-sa1110.c 2005-03-05 16:10:43.000000000 +0100
@@ -271,8 +271,7 @@ static int sa1110_target(struct cpufreq_
*/
sdram_set_refresh(2);
if (!irqs_disabled()) {
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(20 * HZ / 1000);
+ msleep(20);
} else {
mdelay(20);
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* [patch 4/4] arm/cpu-sa1110: replace schedule_timeout() with msleep()
@ 2005-06-20 21:49 domen
0 siblings, 0 replies; 2+ messages in thread
From: domen @ 2005-06-20 21:49 UTC (permalink / raw)
To: rmk; +Cc: linux-kernel, Nishanth Aravamudan, domen
[-- Attachment #1: msleep-arch_arm_mach-sa1100_cpu-sa1110.patch --]
[-- Type: text/plain, Size: 859 bytes --]
From: Nishanth Aravamudan <nacc@us.ibm.com>
Use msleep() instead of schedule_timeout() to guarantee the task
delays as expected. Neither signals nor wait-queue events are important at this
point in the code, I believe.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
cpu-sa1110.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
Index: quilt/arch/arm/mach-sa1100/cpu-sa1110.c
===================================================================
--- quilt.orig/arch/arm/mach-sa1100/cpu-sa1110.c
+++ quilt/arch/arm/mach-sa1100/cpu-sa1110.c
@@ -271,8 +271,7 @@ static int sa1110_target(struct cpufreq_
*/
sdram_set_refresh(2);
if (!irqs_disabled()) {
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(20 * HZ / 1000);
+ msleep(20);
} else {
mdelay(20);
}
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-20 22:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-20 21:49 [patch 4/4] arm/cpu-sa1110: replace schedule_timeout() with msleep() domen
-- strict thread matches above, loose matches on Subject: below --
2005-03-05 22:41 domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox