* [patch 06/12] block/ps2esdi: replace sleep_on() with wait_event()
@ 2005-06-20 21:51 domen
0 siblings, 0 replies; only message in thread
From: domen @ 2005-06-20 21:51 UTC (permalink / raw)
To: axboe; +Cc: linux-kernel, Nishanth Aravamudan, domen
[-- Attachment #1: wait_event-drivers_block_ps2esdi.patch --]
[-- Type: text/plain, Size: 1519 bytes --]
From: Nishanth Aravamudan <nacc@us.ibm.com>
Use wait_event() instead of the deprecated sleep_on(). In all
replacements, wait_event() expects the condition to *stop* on, so the existing
conditional is negated and passed as the parameter. I am not sure if these
changes are appropriate, as the condition to pass to wait_event() to guarantee
the same behavior; I think this is the best choice, though.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
ps2esdi.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
Index: quilt/drivers/block/ps2esdi.c
===================================================================
--- quilt.orig/drivers/block/ps2esdi.c
+++ quilt/drivers/block/ps2esdi.c
@@ -43,6 +43,7 @@
#include <linux/init.h>
#include <linux/ioport.h>
#include <linux/module.h>
+#include <linux/delay.h>
#include <asm/system.h>
#include <asm/io.h>
@@ -461,8 +462,7 @@ static void __init ps2esdi_get_device_cf
cmd_blk[1] = 0;
no_int_yet = TRUE;
ps2esdi_out_cmd_blk(cmd_blk);
- if (no_int_yet)
- sleep_on(&ps2esdi_int);
+ wait_event(ps2esdi_int, !no_int_yet);
if (ps2esdi_drives > 1) {
printk("%s: Drive 1\n", DEVICE_NAME); /*BA */
@@ -470,8 +470,7 @@ static void __init ps2esdi_get_device_cf
cmd_blk[1] = 0;
no_int_yet = TRUE;
ps2esdi_out_cmd_blk(cmd_blk);
- if (no_int_yet)
- sleep_on(&ps2esdi_int);
+ wait_event(ps2esdi_int, !no_int_yet);
} /* if second physical drive is present */
return;
}
--
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-06-21 6:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-20 21:51 [patch 06/12] block/ps2esdi: replace sleep_on() with wait_event() domen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox