public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 12/12] block/cpqarray: Use the DMA_32BIT_MASK constant
@ 2005-06-20 21:51 domen
  0 siblings, 0 replies; only message in thread
From: domen @ 2005-06-20 21:51 UTC (permalink / raw)
  To: axboe; +Cc: linux-kernel, Tobias Klauser, domen

[-- Attachment #1: dma_mask-drivers_block_cpqarray.patch --]
[-- Type: text/plain, Size: 1421 bytes --]

From: Tobias Klauser <tklauser@nuerscht.ch>



Use the DMA_32BIT_MASK constant from dma-mapping.h when calling
pci_set_dma_mask() or pci_set_consistent_dma_mask() instead of custom
macros.
This patch includes dma-mapping.h explicitly because it caused errors
on some architectures otherwise.
See http://marc.theaimsgroup.com/?t=108001993000001&r=1&w=2 for details

Signed-off-by: Tobias Klauser <tklauser@nuerscht.ch>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
 cpqarray.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Index: quilt/drivers/block/cpqarray.c
===================================================================
--- quilt.orig/drivers/block/cpqarray.c
+++ quilt/drivers/block/cpqarray.c
@@ -39,6 +39,7 @@
 #include <linux/spinlock.h>
 #include <linux/blkdev.h>
 #include <linux/genhd.h>
+#include <linux/dma-mapping.h>
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
@@ -65,8 +66,6 @@ MODULE_LICENSE("GPL");
 #define MAX_CTLR	8
 #define CTLR_SHIFT	8
 
-#define CPQARRAY_DMA_MASK	0xFFFFFFFF	/* 32 bit DMA */
-
 static int nr_ctlr;
 static ctlr_info_t *hba[MAX_CTLR];
 
@@ -626,7 +625,7 @@ static int cpqarray_pci_init(ctlr_info_t
 	for(i=0; i<6; i++)
 		addr[i] = pci_resource_start(pdev, i);
 
-	if (pci_set_dma_mask(pdev, CPQARRAY_DMA_MASK) != 0)
+	if (pci_set_dma_mask(pdev, DMA_32BIT_MASK) != 0)
 	{
 		printk(KERN_ERR "cpqarray: Unable to set DMA mask\n");
 		return -1;

--

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-21  6:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-20 21:51 [patch 12/12] block/cpqarray: Use the DMA_32BIT_MASK constant domen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox