From: Gerd Knorr <kraxel@suse.de>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] allow vesafb to build when no CONFIG_MTRR
Date: Tue, 21 Jun 2005 13:14:05 +0200 [thread overview]
Message-ID: <20050621111404.GA16586@bytesex> (raw)
In-Reply-To: <42B802F2020000780001CEAB@lyle.provo.novell.com>
> +#ifdef CONFIG_MTRR
> if (mtrr) {
> - int temp_size = size_total;
> + unsigned int temp_size = size_total;
> /* Find the largest power-of-two */
> while (temp_size & (temp_size - 1))
> temp_size &= (temp_size - 1);
> @@ -396,6 +401,7 @@ static int __init vesafb_probe(struct de
> temp_size >>= 1;
> }
> }
> +#endif
I'd just do that to avoid cluttering up the source with
#ifdef's, otherwise it looks ok to me ;)
Gerd
--
-mm seems unusually stable at present.
-- akpm about 2.6.12-rc3-mm3
next prev parent reply other threads:[~2005-06-21 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 10:07 [PATCH] allow vesafb to build when no CONFIG_MTRR Jan Beulich
2005-06-21 11:14 ` Gerd Knorr [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-06-21 12:25 Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050621111404.GA16586@bytesex \
--to=kraxel@suse.de \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox