From: Michael Buesch <mbuesch@freenet.de>
To: bobl <bobl@turbolinux.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: a trival bug of megaraid in patch 2.6.12-mm1
Date: Tue, 21 Jun 2005 12:20:41 +0200 [thread overview]
Message-ID: <200506211220.42136.mbuesch@freenet.de> (raw)
In-Reply-To: <42B7E5F2.2060409@turbolinux.com>
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
Quoting bobl <bobl@turbolinux.com>:
> The attachment is the patch, please confirm it.
> diff -purN linux-2.6.12/drivers/scsi/megaraid.c linux-2.6.12.new/drivers/scsi/megaraid.c
> --- linux-2.6.12/drivers/scsi/megaraid.c 2005-06-21 18:49:50.118732304 +0900
> +++ linux-2.6.12.new/drivers/scsi/megaraid.c 2005-06-21 18:57:55.266978560 +0900
> @@ -1975,6 +1975,7 @@ __megaraid_reset(Scsi_Cmnd *cmd)
> static int
> megaraid_reset(Scsi_Cmnd *cmd)
> {
> + adapter_t *adapter;
> adapter = (adapter_t *)cmd->device->host->hostdata;
> int rc;
That's mixed code and declarations (aka Not Good (tm)).
Please do something like this instead:
- adapter = (adapter_t *)cmd->device->host->hostdata;
+ adapter_t *adapter = (adapter_t *)cmd->device->host->hostdata;
int rc;
--
Greetings, Michael
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-06-21 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 10:03 a trival bug of megaraid in patch 2.6.12-mm1 bobl
2005-06-21 10:20 ` Michael Buesch [this message]
2005-06-21 10:40 ` bobl
2005-06-21 15:05 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506211220.42136.mbuesch@freenet.de \
--to=mbuesch@freenet.de \
--cc=akpm@osdl.org \
--cc=bobl@turbolinux.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox