From: Alexey Dobriyan <adobriyan@gmail.com>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jeff Garzik <jgarzik@pobox.com>,
Domen Puncer <domen@coderock.org>
Subject: Re: [RFC] cleanup patches for strings
Date: Tue, 21 Jun 2005 12:59:22 +0400 [thread overview]
Message-ID: <200506211259.22650.adobriyan@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0506200052320.2415@dragon.hyggekrogen.localhost>
On Tuesday 21 June 2005 02:46, Jesper Juhl wrote:
> The patches all make the same change, there's just a lot of files the
> change needs to be made in. The change they make is to change strings
> from the form
> [const] char *foo = "blah";
> to
> [const] char foo[] = "blah";
> Below I've just picked 5 of my patches at random to show you what they
> look like. These should not be merged yet.
> --- linux-2.6.12-orig/drivers/isdn/hardware/avm/b1.c
> +++ linux-2.6.12/drivers/isdn/hardware/avm/b1.c
> -static char *revision = "$Revision: 1.1.2.2 $";
> +static char revision[] = "$Revision: 1.1.2.2 $";
Looks good:
16323 104 0 16427 402b drivers/isdn/hardware/avm/b1.o 2.95.3-before
16291 104 0 16395 400b drivers/isdn/hardware/avm/b1.o 2.95.3-after
14643 104 0 14747 399b drivers/isdn/hardware/avm/b1.o 3.3.5-20050130-before
14621 104 0 14725 3985 drivers/isdn/hardware/avm/b1.o 3.3.5-20050130-after
15352 104 0 15456 3c60 drivers/isdn/hardware/avm/b1.o 4.1-20050604-before
15330 104 0 15434 3c4a drivers/isdn/hardware/avm/b1.o 4.1-20050604-after
> --- linux-2.6.12-orig/drivers/net/wireless/wavelan_cs.p.h
> +++ linux-2.6.12/drivers/net/wireless/wavelan_cs.p.h
> -static const char *version = "wavelan_cs.c : v24 (SMP + wireless extensions) 11/1/02\n";
> +static const char version[] = "wavelan_cs.c : v24 (SMP + wireless extensions) 11/1/02\n";
21018 456 0 21474 53e2 drivers/net/wireless/wavelan_cs.o 2.95.3-before
21018 424 0 21442 53c2 drivers/net/wireless/wavelan_cs.o 2.95.3-after
19707 424 12 20143 4eaf drivers/net/wireless/wavelan_cs.o 3.3.5-20050130-before
19707 392 12 20111 4e8f drivers/net/wireless/wavelan_cs.o 3.3.5-20050130-after
17950 424 12 => 18386 <= 47d2 drivers/net/wireless/wavelan_cs.o 4.1-20050604-before
17989 392 12 => 18393 <= 47d9 drivers/net/wireless/wavelan_cs.o 4.1-20050604-after
> --- linux-2.6.12-orig/drivers/net/appletalk/cops.c
> +++ linux-2.6.12/drivers/net/appletalk/cops.c
> -static const char *cardname = "cops";
> +static const char cardname[] = "cops";
Looks good:
14005 100 72 14177 3761 drivers/net/appletalk/cops.o 2.95.3-before
13989 96 72 14157 374d drivers/net/appletalk/cops.o 2.95.3-after
13308 112 72 13492 34b4 drivers/net/appletalk/cops.o 3.3.5-20050130-before
13305 112 72 13489 34b1 drivers/net/appletalk/cops.o 3.3.5-20050130-after
12948 112 72 13132 334c drivers/net/appletalk/cops.o 4.1-20050604-before
12945 112 72 13129 3349 drivers/net/appletalk/cops.o 4.1-20050604-after
> --- linux-2.6.12-orig/drivers/net/sun3lance.c
> +++ linux-2.6.12/drivers/net/sun3lance.c
> -static char *version = "sun3lance.c: v1.2 1/12/2001 Sam Creasey (sammy@sammy.net)\n";
> +static char version[] = "sun3lance.c: v1.2 1/12/2001 Sam Creasey (sammy@sammy.net)\n";
Be sure to have m68k cross-compiler handy.
> --- linux-2.6.12-orig/drivers/net/ibmlana.c
> +++ linux-2.6.12/drivers/net/ibmlana.c
> - char *fill = "NetBSD is a nice OS too! ";
> + char fill[] = "NetBSD is a nice OS too! ";
Don't:
5721 16 4 5741 166d drivers/net/ibmlana.o 2.95.3-before
5737 16 4 5757 167d drivers/net/ibmlana.o 2.95.3-after
5163 16 4 5183 143f drivers/net/ibmlana.o 3.3.5-20050130-before
5169 16 4 5189 1445 drivers/net/ibmlana.o 3.3.5-20050130-after
4993 16 4 5013 1395 drivers/net/ibmlana.o 4.1-20050604-before
5028 16 4 5048 13b8 drivers/net/ibmlana.o 4.1-20050604-after
next prev parent reply other threads:[~2005-06-21 8:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-20 22:46 [RFC] cleanup patches for strings Jesper Juhl
2005-06-21 6:58 ` cutaway
2005-06-21 11:02 ` Denis Vlasenko
2005-06-21 13:08 ` cutaway
2005-06-21 13:06 ` Denis Vlasenko
2005-06-21 14:38 ` cutaway
2005-06-21 13:52 ` Denis Vlasenko
2005-06-21 13:20 ` Denis Vlasenko
2005-06-21 8:59 ` Alexey Dobriyan [this message]
2005-06-21 9:31 ` Jörn Engel
2005-06-21 20:47 ` Jesper Juhl
2005-06-21 9:04 ` Andrey Panin
2005-06-21 10:59 ` Denis Vlasenko
2005-06-21 21:24 ` Jean Delvare
2005-06-21 22:33 ` cutaway
2005-06-21 21:49 ` Jean Delvare
2005-06-21 23:11 ` cutaway
2005-06-22 0:16 ` Brian Gerst
2005-06-21 21:12 ` Horst von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506211259.22650.adobriyan@gmail.com \
--to=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=domen@coderock.org \
--cc=jgarzik@pobox.com \
--cc=juhl-lkml@dif.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox