From: Greg KH <gregkh@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
akpm@osdl.org, mochel@digitalimplant.org, cohuck@de.ibm.com,
linux-kernel@vger.kernel.org
Subject: Re: [patch 1/16] s390: klist bus_find_device & driver_find_device callback.
Date: Wed, 22 Jun 2005 01:19:11 -0700 [thread overview]
Message-ID: <20050622081911.GA30952@suse.de> (raw)
In-Reply-To: <20050622081102.GA3976@infradead.org>
On Wed, Jun 22, 2005 at 09:11:02AM +0100, Christoph Hellwig wrote:
> > +struct device * bus_find_device(struct bus_type * bus, struct device * start,
> > + void * data, int (*match)(struct device *, void *))
> > +{
> > + struct klist_iter i;
> > + struct device * dev;
> > +
> > + if (!bus)
> > + return NULL;
> > +
> > + klist_iter_init_node(&bus->klist_devices, &i,
> > + (start ? &start->knode_bus : NULL));
> > + while ((dev = next_device(&i)))
> > + if (match(dev, data))
> > + break;
> > + klist_iter_exit(&i);
> > + return dev;
>
> does the klist magic somehow grab a reference for you?
No, see my previous comment about the need for this to be fixed for
these two functions.
thanks,
greg k-h
prev parent reply other threads:[~2005-06-22 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 16:22 [patch 1/16] s390: klist bus_find_device & driver_find_device callback Martin Schwidefsky
2005-06-22 6:26 ` Greg KH
2005-06-22 7:48 ` Cornelia Huck
2005-06-22 8:14 ` Greg KH
2005-06-22 14:59 ` Cornelia Huck
2005-06-22 14:59 ` [patch 1/2] " Cornelia Huck
2005-06-22 14:59 ` [patch 2/2] s390: use klist in cio Cornelia Huck
2005-06-22 8:11 ` [patch 1/16] s390: klist bus_find_device & driver_find_device callback Christoph Hellwig
2005-06-22 8:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050622081911.GA30952@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=cohuck@de.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox