From: Arnd Bergmann <arnd@arndb.de>
To: Hollis Blanchard <hollis@penguinppc.org>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc64-dev@ozlabs.org, linux-kernel@vger.kernel.org,
Greg KH <greg@kroah.com>
Subject: Re: [PATCH 10/11] ppc64: SPU file system
Date: Wed, 22 Jun 2005 10:47:13 +0200 [thread overview]
Message-ID: <200506221047.14602.arnd@arndb.de> (raw)
In-Reply-To: <dc0a828aec834a05b3b3fd6d4f6e3426@penguinppc.org>
On Middeweken 22 Juni 2005 02:21, Hollis Blanchard wrote:
> On Jun 21, 2005, at 4:34 PM, Arnd Bergmann wrote:
>
> > +union MFC_TagSizeClassCmd {
>
> I think great effort has gone in to removing so-called "StudlyCaps"
> from the ppc64 iSeries code... :)
Yes. I've been wanting to fix this one for ages, but it keeps
slipping through. The file used to be shared with user space
(bad idea) and the CPU simulator and I tried to at least keep
the structure definitions compatible initially.
> Also, I didn't see "MFC" defined anywhere... it's sort of a pet peeve,
> but could you make sure all your acronyms are defined? Most of them are
> described in spu.h, but a few slipped through I think (like "SMF").
good point
> And while a comment at the top of every file is great, ones like this:
> > +/*
> > + * Low-level SPU handling
> > + *
> might be more helpful if they defined SPU and further mentioned it's
> the coprocessor in the Broadband Processor Architecture...
Yes, all this is the sort of stuff you never notice unless you take
while working on a piece of code for months.
Thanks,
Arnd <><
next prev parent reply other threads:[~2005-06-22 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 21:10 [PATCH 0/11] ppc64: Introduce Cell/BPA platform, v3 Arnd Bergmann
2005-06-21 21:11 ` [PATCH 1/11] ppc64: consolidate calibrate_decr implementations Arnd Bergmann
2005-06-21 21:13 ` [PATCH 2/11] ppc64: rename pSeries rtc functions into rtas_* Arnd Bergmann
2005-06-21 21:17 ` [PATCH 3/11] ppc64: Split out generic rtas code from pSeries_pci.c Arnd Bergmann
2005-06-21 21:18 ` [PATCH 4/11] ppc64: pSeries_progress -> rtas_progress Arnd Bergmann
2005-06-21 21:20 ` [PATCH 5/11] ppc64: add a minimal nvram driver Arnd Bergmann
2005-06-21 21:22 ` [PATCH 6/11] ppc64: add a watchdog driver for rtas Arnd Bergmann
2005-06-21 21:24 ` [PATCH 7/11] ppc64: add BPA platform type Arnd Bergmann
2005-06-21 21:26 ` [PATCH 8/11] ppc64: Add driver for BPA interrupt controllers Arnd Bergmann
2005-06-21 21:28 ` [PATCH 9/11] ppc64: Add driver for BPA iommu Arnd Bergmann
[not found] ` <200506212330.06734.arnd@arndb.de>
2005-06-21 21:31 ` [PATCH 11/11] spufs: Use a system call instead of ioctl Arnd Bergmann
2005-06-21 21:34 ` [PATCH 10/11] ppc64: SPU file system Arnd Bergmann
2005-06-22 0:21 ` Hollis Blanchard
2005-06-22 8:47 ` Arnd Bergmann [this message]
2005-06-21 23:51 ` [PATCH 7/11] ppc64: add BPA platform type Hollis Blanchard
2005-06-22 8:34 ` [PATCH] ppc64: enable BPA nvram driver Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506221047.14602.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=greg@kroah.com \
--cc=hollis@penguinppc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox