From: Greg KH <gregkh@suse.de>
To: roger blofeld <blofeldus@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [W1] Fix slave addition on big-endian platform
Date: Thu, 23 Jun 2005 00:04:33 -0700 [thread overview]
Message-ID: <20050623070433.GB12158@suse.de> (raw)
In-Reply-To: <20050623012732.64286.qmail@web53508.mail.yahoo.com>
On Wed, Jun 22, 2005 at 06:27:32PM -0700, roger blofeld wrote:
> Hi
> In the 2.6.12 code the "rn" structure is in the wrong-endianness when
> passed to w1_attach_slave_device(). This causes problems like the
> family and crc being swapped around. The following patch fixes the
> problem for me.
>
> Signed-off-by: Roger Blofeld <blofeldus@yahoo.com>
Hm, your patch is line-wrapped and the tabs are missing :(
You should also send this to the w1 author/maintainer first, he would
know if this is the correct fix or not.
thanks,
greg k-h
prev parent reply other threads:[~2005-06-23 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 1:27 [W1] Fix slave addition on big-endian platform roger blofeld
2005-06-23 7:04 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050623070433.GB12158@suse.de \
--to=gregkh@suse.de \
--cc=blofeldus@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox