From: Dipankar Sarma <dipankar@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] files: fix dupfd by fdt reload
Date: Fri, 24 Jun 2005 16:22:09 +0530 [thread overview]
Message-ID: <20050624105209.GC4804@in.ibm.com> (raw)
In-Reply-To: <20050624105011.GB4804@in.ibm.com>
locate_fd() may expand fdtable, so the fdtable pointer must be
reloaded after locate_fd(). Fixes bugme #4770.
Signed-off-by: Dipankar Sarma <dipankar@in.ibm.com>
---
fs/fcntl.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
diff -puN fs/fcntl.c~fix-dupfd-reacquire-fdt fs/fcntl.c
--- linux-2.6.12-mm1-fix/fs/fcntl.c~fix-dupfd-reacquire-fdt 2005-06-25 14:56:58.000000000 +0530
+++ linux-2.6.12-mm1-fix-dipankar/fs/fcntl.c 2005-06-25 14:58:26.000000000 +0530
@@ -118,9 +118,10 @@ static int dupfd(struct file *file, unsi
int fd;
spin_lock(&files->file_lock);
- fdt = files_fdtable(files);
fd = locate_fd(files, file, start);
if (fd >= 0) {
+ /* locate_fd() may have expanded fdtable, load the ptr */
+ fdt = files_fdtable(files);
FD_SET(fd, fdt->open_fds);
FD_CLR(fd, fdt->close_on_exec);
spin_unlock(&files->file_lock);
_
next prev parent reply other threads:[~2005-06-24 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-24 10:50 [PATCH 0/4] files: various updates Dipankar Sarma
2005-06-24 10:52 ` Dipankar Sarma [this message]
2005-06-24 10:53 ` [PATCH 2/4] files: fix expand_files return code Dipankar Sarma
2005-06-24 10:54 ` [PATCH 3/4] files: change fd_install assertion Dipankar Sarma
2005-06-24 10:55 ` [PATCH 4/4] files: doc update Dipankar Sarma
2005-06-24 12:04 ` [PATCH 3/4] files: change fd_install assertion Artem B. Bityuckiy
2005-06-24 13:00 ` Dipankar Sarma
2005-06-24 13:55 ` Artem B. Bityuckiy
2005-06-24 14:09 ` Dipankar Sarma
2005-06-24 14:20 ` Artem B. Bityuckiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050624105209.GC4804@in.ibm.com \
--to=dipankar@in.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox