From: Christoph Hellwig <hch@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, Steven French <sfrench@us.ibm.com>
Subject: Re: Fwd: Re: [patch 1/3] __leify posix_acl_xattr_entry, posix_acl_xattr_header
Date: Sun, 26 Jun 2005 13:34:26 +0100 [thread overview]
Message-ID: <20050626123426.GA15281@infradead.org> (raw)
In-Reply-To: <200506222246.32763.adobriyan@gmail.com>
On Wed, Jun 22, 2005 at 10:46:32PM +0400, Alexey Dobriyan wrote:
> Christoph, can you comment on what Steve said to my patch which is exactly
> the same as yours acl-endianess-annotations.patch?
Sure.
> ============================================================================
> From: Steven French <sfrench@us.ibm.com>
>
> You may be correct, but making the in memory representations of these
> structions little endian seems wrong and I would be surprised if it were
> little endian, but I have not had time to think through what happens when a
> local filesystem takes an existing hard drive with ACLs on various inodes
> and moves the drive from a little endian to a big endian machine and the
> endian implications on this structure.
>
> Although the representation on the wire for the cifs protocol is clearly
> little endian for the acl entries, I am uncomfortable with changes to the
> in memory representation until I do more checking.
I have asked myself that question aswell. The odd thing about our posix
ACL implementation is that the ACL data passed to the xattr syscalls is
_always_ little endian, which is what the structure in this file define.
The incore represenation is in posix_acl.h and is always little endian.
prev parent reply other threads:[~2005-06-26 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-22 18:46 Fwd: Re: [patch 1/3] __leify posix_acl_xattr_entry, posix_acl_xattr_header Alexey Dobriyan
2005-06-26 12:34 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050626123426.GA15281@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox