* fix silly config option.
@ 2005-06-27 5:39 Dave Jones
2005-06-27 11:21 ` Adrian Bunk
2005-06-27 19:03 ` Michael Krufky
0 siblings, 2 replies; 6+ messages in thread
From: Dave Jones @ 2005-06-27 5:39 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds
CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
author meant to create.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.12/drivers/media/video/Kconfig~ 2005-06-27 01:37:39.000000000 -0400
+++ linux-2.6.12/drivers/media/video/Kconfig 2005-06-27 01:37:56.000000000 -0400
@@ -7,7 +7,7 @@ menu "Video For Linux"
comment "Video Adapters"
-config CONFIG_TUNER_MULTI_I2C
+config TUNER_MULTI_I2C
bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
depends on VIDEO_DEV && EXPERIMENTAL
---help---
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fix silly config option.
2005-06-27 5:39 fix silly config option Dave Jones
@ 2005-06-27 11:21 ` Adrian Bunk
2005-06-27 15:02 ` Dave Jones
2005-06-27 19:03 ` Michael Krufky
1 sibling, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-06-27 11:21 UTC (permalink / raw)
To: Dave Jones, linux-kernel, torvalds
On Mon, Jun 27, 2005 at 01:39:28AM -0400, Dave Jones wrote:
> CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
> author meant to create.
>...
I can't find this option.
Which kernel is this patch against?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: fix silly config option.
2005-06-27 5:39 fix silly config option Dave Jones
2005-06-27 11:21 ` Adrian Bunk
@ 2005-06-27 19:03 ` Michael Krufky
2005-06-27 19:07 ` Dave Jones
1 sibling, 1 reply; 6+ messages in thread
From: Michael Krufky @ 2005-06-27 19:03 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
Dave Jones wrote:
>CONFIG_CONFIG_TUNER_MULTI_I2C probably isn't what the
>author meant to create.
>
>Signed-off-by: Dave Jones <davej@redhat.com>
>
>--- linux-2.6.12/drivers/media/video/Kconfig~ 2005-06-27 01:37:39.000000000 -0400
>+++ linux-2.6.12/drivers/media/video/Kconfig 2005-06-27 01:37:56.000000000 -0400
>@@ -7,7 +7,7 @@ menu "Video For Linux"
>
> comment "Video Adapters"
>
>-config CONFIG_TUNER_MULTI_I2C
>+config TUNER_MULTI_I2C
> bool "Enable support for multiple I2C devices on Video Adapters (EXPERIMENTAL)"
> depends on VIDEO_DEV && EXPERIMENTAL
> ---help---
>
>
Dave-
If you do:
grep TUNER_MULTI_I2C < patch-2.6.12-git9
you will get:
+config CONFIG_TUNER_MULTI_I2C
+#define CONFIG_TUNER_MULTI_I2C /**/
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
+#ifndef CONFIG_TUNER_MULTI_I2C
+#ifdef CONFIG_TUNER_MULTI_I2C
... So in fact, after applying your patch above, NOW it is a silly
config option, which in effect, removed all functionality of
CONFIG_TUNER_MULTI_I2C alltogether. It so happens that this has been
completely removed in the current -mm, and I've confirmed with Mauro
Chehab (video4linux maintainer) that nothing will be broken after
applying your patch, so there is nothing to worry about. After the
current tuner patches in -mm get merged, this whole thing will be a moot
point.
--
Michael Krufky
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fix silly config option.
2005-06-27 19:03 ` Michael Krufky
@ 2005-06-27 19:07 ` Dave Jones
2005-06-27 19:09 ` Michael Krufky
0 siblings, 1 reply; 6+ messages in thread
From: Dave Jones @ 2005-06-27 19:07 UTC (permalink / raw)
To: Michael Krufky; +Cc: linux-kernel
On Mon, Jun 27, 2005 at 03:03:30PM -0400, Michael Krufky wrote:
> +config CONFIG_TUNER_MULTI_I2C
> +#define CONFIG_TUNER_MULTI_I2C /**/
> +#ifdef CONFIG_TUNER_MULTI_I2C
> +#ifdef CONFIG_TUNER_MULTI_I2C
> +#ifdef CONFIG_TUNER_MULTI_I2C
> +#ifndef CONFIG_TUNER_MULTI_I2C
> +#ifdef CONFIG_TUNER_MULTI_I2C
>
> ... So in fact, after applying your patch above, NOW it is a silly
> config option, which in effect, removed all functionality of
> CONFIG_TUNER_MULTI_I2C alltogether
Err, no. Note how no other config options have CONFIG_ prepended
to them. Kconfig magic does this for you implicitly.
Dave
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: fix silly config option.
2005-06-27 19:07 ` Dave Jones
@ 2005-06-27 19:09 ` Michael Krufky
0 siblings, 0 replies; 6+ messages in thread
From: Michael Krufky @ 2005-06-27 19:09 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
Dave Jones wrote:
>On Mon, Jun 27, 2005 at 03:03:30PM -0400, Michael Krufky wrote:
>
> > +config CONFIG_TUNER_MULTI_I2C
> > +#define CONFIG_TUNER_MULTI_I2C /**/
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> > +#ifndef CONFIG_TUNER_MULTI_I2C
> > +#ifdef CONFIG_TUNER_MULTI_I2C
> >
> > ... So in fact, after applying your patch above, NOW it is a silly
> > config option, which in effect, removed all functionality of
> > CONFIG_TUNER_MULTI_I2C alltogether
>
>Err, no. Note how no other config options have CONFIG_ prepended
>to them. Kconfig magic does this for you implicitly.
>
OOPS! I stand corrected. :-)
--
Michael Krufky
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-06-27 19:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-27 5:39 fix silly config option Dave Jones
2005-06-27 11:21 ` Adrian Bunk
2005-06-27 15:02 ` Dave Jones
2005-06-27 19:03 ` Michael Krufky
2005-06-27 19:07 ` Dave Jones
2005-06-27 19:09 ` Michael Krufky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox