From: Jens Axboe <axboe@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: Re: cfq build breakage
Date: Tue, 28 Jun 2005 11:43:43 +0200 [thread overview]
Message-ID: <20050628094341.GG4410@suse.de> (raw)
In-Reply-To: <20050628072520.GA3668@suse.de>
On Tue, Jun 28 2005, Jens Axboe wrote:
> > > > @@ -1969,7 +1968,7 @@ __cfq_may_queue(struct cfq_data *cfqd, s
> > > > * only allow 1 ELV_MQUEUE_MUST per slice, otherwise we
> > > > * can quickly flood the queue with writes from a single task
> > > > */
> > > > - if (rw == READ || !cfq_cfqq_must_alloc_slice) {
> > > > + if (rw == READ || !cfq_cfqq_must_alloc_slice(cfqq)) {
> > > > cfq_mark_cfqq_must_alloc_slice(cfqq);
> > > > return ELV_MQUEUE_MUST;
> > > > }
> > >
> > > thanks, clearly a typo but inside if 0.
> >
> > But the other instance was inside `#if 1'. This fixup will change behaviour.
>
> Hrmpf strange, I submitted what I built. Must be some silly slip up
> here.
Ok double checked, and the above actually builds with gcc 3.3.5 without
any warnings. I've verified the change here, it is sound and acts as it
should.
--
Jens Axboe
prev parent reply other threads:[~2005-06-28 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 2:19 cfq build breakage Jeff Garzik
2005-06-28 3:13 ` Andrew Morton
2005-06-28 3:31 ` Jeff Garzik
2005-06-28 6:21 ` Jens Axboe
2005-06-28 6:30 ` Andrew Morton
2005-06-28 7:25 ` Jens Axboe
2005-06-28 9:43 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628094341.GG4410@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox