From: Christoph Hellwig <hch@lst.de>
To: markus.lidel@shadowconnect.com, gregkh@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: sysfs abuse in recent i2o changes
Date: Tue, 28 Jun 2005 13:21:02 +0200 [thread overview]
Message-ID: <20050628112102.GA1111@lst.de> (raw)
drivers/message/i2o/config-osm.c has a function sysfs_create_fops_file,
which creates a sysfs file with supplied file_operations. This is
pretty much against the sysfs design which only wants simple attributes,
ascsii or for corner cases binary.
Also, if we're going to allow this code it should move to sysfs. And
stop using lookup_hash directly (use lookup_one_len instead), it'll go
away soon.
next reply other threads:[~2005-06-28 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 11:21 Christoph Hellwig [this message]
2005-06-28 15:02 ` sysfs abuse in recent i2o changes Markus Lidel
2005-06-28 16:21 ` Greg KH
2005-06-28 18:08 ` Markus Lidel
2005-06-28 18:07 ` Greg KH
2005-06-29 8:33 ` Markus Lidel
2005-07-08 6:00 ` Greg KH
2005-07-08 11:11 ` Markus Lidel
2005-07-31 14:09 ` Christoph Hellwig
2005-07-31 15:40 ` Markus Lidel
2005-07-31 21:19 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628112102.GA1111@lst.de \
--to=hch@lst.de \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.lidel@shadowconnect.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox