From: Greg KH <greg@kroah.com>
To: Vitaly Wool <vwool@dev.rtsoft.ru>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] SPI core -- revisited
Date: Tue, 28 Jun 2005 09:49:16 -0700 [thread overview]
Message-ID: <20050628164916.GA10811@kroah.com> (raw)
In-Reply-To: <42BFD2EA.5060808@dev.rtsoft.ru>
On Mon, Jun 27, 2005 at 02:20:26PM +0400, Vitaly Wool wrote:
> But -- does the interfaces review imply checking wthether the figure
> brackets are complying to K&R? ;)
Yes. If you get the coding style wrong, it's harder for all of us to
review the code. See my old OLS paper about coding style for the
research that backs this up.
Basically, if the format is wrong, your brain has a much harder time to
see the actual logic of your code. And you want us to review the logic
:)
thanks,
greg k-h
next prev parent reply other threads:[~2005-06-28 16:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-26 19:36 [RFC] SPI core -- revisited dpervushin
2005-06-26 20:49 ` Alexey Dobriyan
2005-06-26 20:59 ` Arjan van de Ven
2005-06-27 3:37 ` Vitaly Wool
2005-06-27 8:28 ` Arjan van de Ven
2005-06-27 9:13 ` Vitaly Wool
2005-06-27 9:20 ` Russell King
2005-06-27 10:20 ` Vitaly Wool
2005-06-28 16:49 ` Greg KH [this message]
2005-06-27 3:39 ` Vitaly Wool
-- strict thread matches above, loose matches on Subject: below --
2005-06-23 12:18 dmitry pervushin
2005-06-23 15:50 ` Jamey Hicks
2005-06-23 16:43 ` Russell King
2005-06-24 12:56 ` Jamey Hicks
2005-06-23 21:59 ` Jean Delvare
2005-06-24 0:35 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628164916.GA10811@kroah.com \
--to=greg@kroah.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=vwool@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox