From: Jean Delvare <khali@linux-fr.org>
To: Chris Wright <chrisw@osdl.org>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org, akpm@osdl.org,
tytso@mit.edu, zwane@arm.linux.org.uk, jmforbes@linuxtx.org,
rdunlap@xenotime.net, torvalds@osdl.org, chuckw@quantumlinux.com,
alan@lxorguk.ukuu.org.uk,
Andrew Vasquez <andrew.vasquez@qlogic.com>,
James Bottomley <James.Bottomley@SteelEye.com>
Subject: Re: [02/07] [SCSI] qla2xxx: Pull-down scsi-host-addition to follow board initialization.
Date: Tue, 28 Jun 2005 23:51:48 +0200 [thread overview]
Message-ID: <20050628235148.4512d046.khali@linux-fr.org> (raw)
In-Reply-To: <20050627225349.GK9046@shell0.pdx.osdl.net>
Hi Chris, all,
> -stable review patch. If anyone has any objections, please let us
> know.
I have. This one patch is rather big and parts of it don't seem to
belong to -stable. Can't it be simplified? More below.
> Return to previous held-logic of calling scsi_add_host() only
> after the board has been completely initialized.
What real bug is it supposed to fix? (I guess some, but this leading
comment should give the datails.)
> Also return pci_*() error-codes during probe failure paths.
How does this belong to stable please? I don't see this fixing any
critical bug.
> This also corrects an issue where only lun 0 is being scanned for
> a given port.
This OTOH is probably OK.
> - if (ret != 0) {
> - goto probe_alloc_failed;
> - }
> + if (ret)
> + goto probe_failed;
This change can be made smaller.
> - if (ret != 0) {
> + if (ret) {
This aint -stable material.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2005-06-28 21:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-27 22:46 [00/07] -stable review Chris Wright
2005-06-27 22:50 ` [01/07] Fix typo in drivers/pci/pci-driver.c Chris Wright
2005-06-27 22:53 ` [02/07] [SCSI] qla2xxx: Pull-down scsi-host-addition to follow board initialization Chris Wright
2005-06-28 21:51 ` Jean Delvare [this message]
2005-06-28 22:20 ` Andrew Morton
2005-06-28 22:30 ` Chris Wright
2005-06-28 23:09 ` Andrew Morton
2005-06-28 23:16 ` Chris Wright
2005-06-28 22:32 ` [stable] " Greg KH
2005-06-29 8:08 ` Jean Delvare
2005-06-29 16:36 ` James Bottomley
2005-07-01 11:32 ` Jean Delvare
2005-06-27 22:55 ` [03/07] fix remap_pte_range BUG Chris Wright
2005-06-27 22:59 ` [04/07] e1000: fix spinlock bug Chris Wright
2005-06-27 23:01 ` [05/07] Add "memory" clobbers to the x86 inline asm of strncmp and friends Chris Wright
2005-06-28 21:57 ` Jean Delvare
2005-06-27 23:03 ` [06/07] ACPI: Make sure we call acpi_register_gsi() even for default PCI interrupt assignment Chris Wright
2005-06-27 23:05 ` [07/07] [NETLINK]: Fix two socket hashing bugs Chris Wright
2005-06-28 12:10 ` [00/07] -stable review Jim MacBaine
2005-06-28 14:47 ` [stable] " Chris Wright
2005-06-28 17:18 ` Jim MacBaine
2005-06-28 17:20 ` Chris Wright
2005-06-28 20:45 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628235148.4512d046.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrew.vasquez@qlogic.com \
--cc=chrisw@osdl.org \
--cc=chuckw@quantumlinux.com \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox