Re: [02/07] [SCSI] qla2xxx: Pull-down scsi-host-addition to follow board initialization.

Jean Delvare
2005-06-28T21:54:06Z

Hi Chris, all,

> -stable review patch. If anyone has any objections, please let us
> know.

I have. This one patch is rather big and parts of it don't seem to
belong to -stable. Can't it be simplified? More below.

> Return to previous held-logic of calling scsi_add_host() only
> after the board has been completely initialized.

What real bug is it supposed to fix? (I guess some, but this leading
comment should give the datails.)

> Also return pci_*() error-codes during probe failure paths.

How does this belong to stable please? I don't see this fixing any
critical bug.

> This also corrects an issue where only lun 0 is being scanned for
> a given port.

This OTOH is probably OK.

> - if (ret != 0) {
> - goto probe_alloc_failed;
> - }
> + if (ret)
> + goto probe_failed;

This change can be made smaller.

> - if (ret != 0) {
> + if (ret) {

This aint -stable material.

Thanks,
--
Jean Delvare