public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Gernot Payer <gpayer@suse.de>
To: linux-kernel@vger.kernel.org
Subject: Patch to disarm timers after an exec syscall
Date: Wed, 29 Jun 2005 14:55:45 +0200	[thread overview]
Message-ID: <200506291455.45468.gpayer@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 735 bytes --]

Hi all,

while running the openposix testsuite I saw testcase timer_create/9-1.c 
failing. This testcase tests whether timers are disarmed when a process calls 
exec, as described in e.g. 
http://www.opengroup.org/onlinepubs/009695399/functions/timer_create.html.

The attached one-liner patch (+ one line comment) fixes this issue. I did the 
diff against 2.6.12.1, but the fix is pretty much the same for every other 
2.6.x kernel I had a look at.

I don't think this patch breaks anything, as relying on this (undocumented) 
behaviour would imho be bad style.

So tell me what you think, and if you have some pointers to interesting 
discussions about Linux and POSIX compliance then I would like to read that 
as well.

mfg
Gernot

[-- Attachment #2: delete-old-itimers-in-do_execve-linux-2.6.12.1.patch --]
[-- Type: text/x-diff, Size: 333 bytes --]

--- linux-2.6.12.1-orig/fs/exec.c	2005-06-29 14:29:31.069738264 +0200
+++ linux-2.6.12.1/fs/exec.c	2005-06-29 14:34:46.034856288 +0200
@@ -1200,6 +1200,10 @@
 		acct_update_integrals(current);
 		update_mem_hiwater(current);
 		kfree(bprm);
+
+		/* delete old itimers */
+		exit_itimers(current->signal);
+		
 		return retval;
 	}
 

             reply	other threads:[~2005-06-29 12:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-29 12:55 Gernot Payer [this message]
2005-06-29 18:15 ` Patch to disarm timers after an exec syscall Andrew Morton
2005-06-29 18:31   ` Chris Wright
2005-06-29 18:50   ` Roland McGrath
2005-06-30  8:34     ` Gernot Payer
2005-06-29 18:27 ` Chris Wright
2005-06-30  8:27   ` Gernot Payer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200506291455.45468.gpayer@suse.de \
    --to=gpayer@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox