From: Jens Axboe <axboe@suse.de>
To: Hugh Dickins <hugh@veritas.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.6.13-rc1 get_request nastiness
Date: Wed, 29 Jun 2005 19:58:05 +0200 [thread overview]
Message-ID: <20050629175805.GA15356@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0506291509170.13974@goblin.wat.veritas.com>
On Wed, Jun 29 2005, Hugh Dickins wrote:
> get_request is now expected to be holding on to queue_lock, with interrupts
> disabled, when it returns NULL; but one path forgot that, causing all kinds
> of nastiness under swap load - badness backtraces, strange failures, BUGs.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
>
> --- 2.6.13-rc1/drivers/block/ll_rw_blk.c 2005-06-29 11:54:08.000000000 +0100
> +++ linux/drivers/block/ll_rw_blk.c 2005-06-29 14:41:04.000000000 +0100
> @@ -1917,10 +1917,9 @@ get_rq:
> * limit of requests, otherwise we could have thousands of requests
> * allocated with any setting of ->nr_requests
> */
> - if (rl->count[rw] >= (3 * q->nr_requests / 2)) {
> - spin_unlock_irq(q->queue_lock);
> + if (rl->count[rw] >= (3 * q->nr_requests / 2))
> goto out;
> - }
> +
Woops, my bad, sorry about that. I still have to think about that
locking, not directly obvious. Thanks Hugh!
--
Jens Axboe
prev parent reply other threads:[~2005-06-29 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-29 14:15 [PATCH] 2.6.13-rc1 get_request nastiness Hugh Dickins
2005-06-29 17:58 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050629175805.GA15356@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox