[-mm patch] CONFIGFS_FS shouldn't be user-visible

[-mm patch] CONFIGFS_FS shouldn't be user-visible

[Adrian Bunk]

I haven't found any reason why CONFIGFS_FS is user-visible.
Other parts of the kernel using configfs should simply select it.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-mm1-full/fs/Kconfig.old	2005-06-21 23:19:19.000000000 +0200
+++ linux-2.6.12-mm1-full/fs/Kconfig	2005-06-21 23:22:30.000000000 +0200
@@ -981,16 +981,7 @@
 	  ramfs.
 
 config CONFIGFS_FS
-	tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
-	help
-	  configfs is a ram-based filesystem that provides the converse
-	  of sysfs's functionality. Where sysfs is a filesystem-based
-	  view of kernel objects, configfs is a filesystem-based manager
-	  of kernel objects, or config_items.
-
-	  Both sysfs and configfs can and should exist together on the
-	  same system. One is not a replacement for the other.
+	tristate
 
 config RELAYFS_FS
 	tristate "Relayfs file system support"

Re: [-mm patch] CONFIGFS_FS shouldn't be user-visible

[Joel Becker]

On Fri, Jun 24, 2005 at 10:03:15AM +0200, Adrian Bunk wrote:
> I haven't found any reason why CONFIGFS_FS is user-visible.
> Other parts of the kernel using configfs should simply select it.

	Doesn't work for external modules that might want to use it.
Imagine that configfs gets merged before OCFS2, which depends on it.

Joel

-- 

"There is shadow under this red rock.
 (Come in under the shadow of this red rock)
 And I will show you something different from either
 Your shadow at morning striding behind you
 Or your shadow at evening rising to meet you.
 I will show you fear in a handful of dust."

Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

[-mm patch] CONFIGFS_FS: "If unsure, say N."

[Adrian Bunk]

On Wed, Jun 29, 2005 at 02:30:38PM -0700, Joel Becker wrote:
> On Fri, Jun 24, 2005 at 10:03:15AM +0200, Adrian Bunk wrote:
> > I haven't found any reason why CONFIGFS_FS is user-visible.
> > Other parts of the kernel using configfs should simply select it.
> 
> 	Doesn't work for external modules that might want to use it.
> Imagine that configfs gets merged before OCFS2, which depends on it.

I was surprised if configfs was merged with zero users in the kernel.

But I get your point, what about the patch below?

> Joel

cu
Adrian


<--  snip  -->


Make it clear that users usually shouldn't manually enable CONFIGFS_FS.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.12-mm2-full/fs/Kconfig.old	2005-06-30 01:51:51.000000000 +0200
+++ linux-2.6.12-mm2-full/fs/Kconfig	2005-06-30 01:54:01.000000000 +0200
@@ -934,13 +934,11 @@
 	tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	help
-	  configfs is a ram-based filesystem that provides the converse
-	  of sysfs's functionality. Where sysfs is a filesystem-based
-	  view of kernel objects, configfs is a filesystem-based manager
-	  of kernel objects, or config_items.
+	  This option is provided for the case where no in-kernel-tree
+	  modules require configfs, but a module built outside the kernel
+	  tree does. Such modules require Y or M here.
 
-	  Both sysfs and configfs can and should exist together on the
-	  same system. One is not a replacement for the other.
+	  If unsure, say N.
 
 config RELAYFS_FS
 	tristate "Relayfs file system support"

Re: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."

[Joel Becker]

On Thu, Jun 30, 2005 at 02:47:38AM +0200, Adrian Bunk wrote:
> But I get your point, what about the patch below?

	Non-descriptive.  We are descriptive for sysfs (and even allow
the choice!).  I'd say that leaving the description but perhaps adding
the caveat about modules and unsure-N might be a good way to go.

Joel

-- 

"If you are ever in doubt as to whether or not to kiss a pretty girl, 
 give her the benefit of the doubt"
                                        -Thomas Carlyle

Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

Re: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."

[Adrian Bunk]

On Wed, Jun 29, 2005 at 05:57:23PM -0700, Joel Becker wrote:
> On Thu, Jun 30, 2005 at 02:47:38AM +0200, Adrian Bunk wrote:
> > But I get your point, what about the patch below?
> 
> 	Non-descriptive.  We are descriptive for sysfs (and even allow
> the choice!).  I'd say that leaving the description but perhaps adding
> the caveat about modules and unsure-N might be a good way to go.

The question is:
Assume a user doesn't use external modules, will enabling this option 
have any effect for him except that it wastes some bytes of his RAM?

sysfs is useful in this case.
How is configfs useful in this case?

> Joel

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [Ocfs2-devel] [-mm patch] CONFIGFS_FS: "If unsure, say N."

[Joel Becker]

On Thu, Jun 30, 2005 at 03:10:15AM +0200, Adrian Bunk wrote:
> The question is:
> Assume a user doesn't use external modules, will enabling this option 
> have any effect for him except that it wastes some bytes of his RAM?
> 
> sysfs is useful in this case.
> How is configfs useful in this case?

	I'm not saying it is.  I'm saying that "Hey, if you are unsure
you want 'N'" is a good thing to say, but removing the description of
"what configfs is" is unhelpful and unneeded.

Joel

-- 

"And yet I fight,
 And yet I fight this battle all alone.
 No one to cry to;
 No place to call home."

Joel Becker
Senior Member of Technical Staff
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

[-mm patch] CONFIGFS_FS: "If unsure, say N."

[Adrian Bunk]

On Wed, Jun 29, 2005 at 06:30:11PM -0700, Joel Becker wrote:
> On Thu, Jun 30, 2005 at 03:10:15AM +0200, Adrian Bunk wrote:
> > The question is:
> > Assume a user doesn't use external modules, will enabling this option 
> > have any effect for him except that it wastes some bytes of his RAM?
> > 
> > sysfs is useful in this case.
> > How is configfs useful in this case?
> 
> 	I'm not saying it is.  I'm saying that "Hey, if you are unsure
> you want 'N'" is a good thing to say, but removing the description of
> "what configfs is" is unhelpful and unneeded.

OK, what about the patch below?

> Joel

cu
Adrian



<--  snip  -->


Make it clear that users usually shouldn't manually enable CONFIGFS_FS.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-rc1-mm1-full/fs/Kconfig.old	2005-07-02 12:50:23.000000000 +0200
+++ linux-2.6.13-rc1-mm1-full/fs/Kconfig	2005-07-02 12:51:05.000000000 +0200
@@ -936,24 +936,30 @@
 config CONFIGFS_FS
 	tristate "Userspace-driven configuration filesystem (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
 	help
 	  configfs is a ram-based filesystem that provides the converse
 	  of sysfs's functionality. Where sysfs is a filesystem-based
 	  view of kernel objects, configfs is a filesystem-based manager
 	  of kernel objects, or config_items.
 
 	  Both sysfs and configfs can and should exist together on the
 	  same system. One is not a replacement for the other.
 
+	  This option is provided for the case where no in-kernel-tree
+	  modules require configfs, but a module built outside the kernel
+	  tree does. Such modules require Y or M here.
+
+	  If unsure, say N.
+
 config RELAYFS_FS
 	tristate "Relayfs file system support"
 	---help---
 	  Relayfs is a high-speed data relay filesystem designed to provide
 	  an efficient mechanism for tools and facilities to relay large
 	  amounts of data from kernel space to user space.
 
 	  To compile this code as a module, choose M here: the module will be
 	  called relayfs.
 
 	  If unsure, say N.