Re: [PATCH] deinline sleep/delay functions

Arjan van de Ven
2005-06-30T09:20:18Z

> > There are a number of compile-time checks that your patch has removed
> > which catch such things, and as such your patch is not acceptable.
> > Some architectures have a lower threshold of acceptability for the
> > maximum udelay value, so it's absolutely necessary to keep this.
>
> It removes that check from x86 - other architectures retain it.
>
> I don't recall seeing anyone trigger the check,

I do ;) Esp in vendor out of tree crap. It's a good compile time
diagnostic so the junk code doesnt' hit mainline but gets fixed first.

>
> and it hardly seems worth
> adding a "few kb" to vmlinux for it?

but it can be fixed to not add that few kb while retaining the checking
value. All that needs is for it to be a define that calls the worker
function. Eg the check gets optimized out and all that remains is the
call to the worker function that does the actual delay.