From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@lst.de>,
cotte@de.ibm.com, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xip cleanups
Date: Thu, 30 Jun 2005 15:44:23 +0200 [thread overview]
Message-ID: <20050630134423.GA14319@lst.de> (raw)
In-Reply-To: <200506281421.09893.arnd@arndb.de>
On Tue, Jun 28, 2005 at 02:21:09PM +0200, Arnd Bergmann wrote:
> On Dinsdag 28 Juni 2005 14:01, Christoph Hellwig wrote:> ?int> -ext2_clear_xip_target(struct inode *inode, int block) {> -???????sector_t sector = block*(PAGE_SIZE/512);> +ext2_clear_xip_target(struct inode *inode, int block)> +{> +???????sector_t sector = block * (PAGE_SIZE/512);> ????????unsigned long data;> ????????int rc;> ?> ????????rc = __inode_direct_access(inode, sector, &data);> -???????if (rc)> -???????????????return rc;> -???????clear_page((void*)data);> -???????return 0;> +???????if (!rc)> +???????????????clear_page(data);> +???????return rc;> ?}
> Did you try building it? While most of your changes areobviously correct, passing an unsigned long value to clear_pagewithout a cast isn't.
On what hardware? ;-) Ok, that one is indeed bogus.
Btw, you mailer totally messed up the quoted part.
prev parent reply other threads:[~2005-06-30 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 12:01 [PATCH] xip cleanups Christoph Hellwig
2005-06-28 12:40 ` Jörn Engel
2005-06-30 13:46 ` Christoph Hellwig
[not found] ` <200506281421.09893.arnd@arndb.de>
2005-06-30 13:44 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050630134423.GA14319@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=cotte@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox