From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Olivier Croquette <ocroquette@free.fr>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: setitimer expire too early (Kernel 2.4)
Date: Fri, 1 Jul 2005 11:49:01 -0300 [thread overview]
Message-ID: <20050701144901.GC11975@logos.cnet> (raw)
In-Reply-To: <42C582CC.5050907@free.fr>
Hi Olivier,
On Fri, Jul 01, 2005 at 07:52:12PM +0200, Olivier Croquette wrote:
> Andrew Morton wrote:
> >>Linus, Andrew, do you consider this critical enough to be merged to
> >>the v2.4 tree?
> >
> >
> >No. I'd expect this would hurt more people than it would benefit.
>
>
> Probably.
> Does that mean that the kernel 2.4 will keep this bug for ever?
Probably, yes. I've never heard such complaints before your message.
The right way to do it seems something else BTW:
quoting Nish Aravamudan (http://lkml.org/lkml/2005/4/29/240):
Your patch is the only way to guarantee no early timeouts, as far as I know.
Really, what you want is:
on adding timers, take the ceiling of the interval into which it could be added
on expiring timers, take the floor
This combination guarantees no timers go off early (and takes away
many of these corner cases). I do exactly this in my patch, btw.
next prev parent reply other threads:[~2005-07-01 19:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-30 19:14 setitimer expire too early (Kernel 2.4) Olivier Croquette
2005-06-30 16:50 ` Marcelo Tosatti
2005-06-30 21:59 ` Willy Tarreau
2005-06-30 23:05 ` Andrew Morton
2005-07-01 9:44 ` George Anzinger
2005-07-01 17:52 ` Olivier Croquette
2005-07-01 14:49 ` Marcelo Tosatti [this message]
2005-07-01 21:14 ` George Anzinger
2005-07-03 11:56 ` Marcelo Tosatti
2005-07-04 11:47 ` Marcelo Tosatti
2005-06-30 21:46 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050701144901.GC11975@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ocroquette@free.fr \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox